This is an archive of the discontinued LLVM Phabricator instance.

Set completion priority of destructors and operators to CCP_Unlikely.
ClosedPublic

Authored by ilya-biryukov on Sep 20 2017, 7:11 AM.

Details

Summary

It will move destructors and operators to the end of completion list.
Destructors and operators are currently very high on the completion
list, as they have the same priority as member functions. However,
they are clearly not something users usually choose in completion
lists.

Event Timeline

ilya-biryukov created this revision.Sep 20 2017, 7:11 AM
krasimir edited edge metadata.Sep 20 2017, 7:50 AM

+1! I totally agree with this!

Friendly ping. Any suggestions for other reviewers are also very welcome.

arphaman accepted this revision.Sep 22 2017, 11:14 AM

Nice, LGTM

Please keep in mind that LLVM follows a weekly ping rate: https://llvm.org/docs/DeveloperPolicy.html#code-reviews .

lib/Sema/SemaCodeComplete.cpp
751

Nit: NameKind:: is redundant.

This revision is now accepted and ready to land.Sep 22 2017, 11:14 AM
ilya-biryukov marked an inline comment as done.
  • Removed redundant NameKind:: qualifiers.

Thanks for the review!
Sorry for inappropriate ping, I'll make sure to stick to the policy.

This revision was automatically updated to reflect the committed changes.