This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Relax `cpsie`/`cpsid` flag parsing.
ClosedPublic

Authored by jroelofs on Sep 16 2017, 6:11 PM.

Details

Summary

The ARM docs suggest in examples that the flags can have either case, and there are applications in the wild that (libopencm3, for example) that expect to be able to use the uppercase spelling.

Diff Detail

Event Timeline

jroelofs created this revision.Sep 16 2017, 6:11 PM

This looks like the right change to make. There isn't anything written down about case-sensitivity in unified assembly language syntax that I could find in the Arm ARM, the best I could find was in the Armasm documentation http://infocenter.arm.com/help/topic/com.arm.doc.dui0473m/dom1359731141352.html "Considerations when writing assembly language source code", which implies that all lower case or all upper case is acceptable. I think the only potential problem would be if the same letter meant two different things in upper and lower case and I can't think of any case where that happens. Both armasm and gcc seem to be fine with AIF as well as aif.

compnerd accepted this revision.Sep 19 2017, 10:36 AM

Yeah, this is supposed to be case insensitive.

This revision is now accepted and ready to land.Sep 19 2017, 10:36 AM
jroelofs closed this revision.Sep 19 2017, 2:25 PM

r313680