This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] calling conventions for AMDPAL OS type
ClosedPublic

Authored by tpr on Sep 12 2017, 11:26 AM.

Details

Summary

This commit adds comments on how the AMDPAL OS type overloads the
existing AMDGPU_ calling conventions used by Mesa, and adds a couple of
new ones.

Diff Detail

Repository
rL LLVM

Event Timeline

tpr created this revision.Sep 12 2017, 11:26 AM
arsenm edited edge metadata.Sep 12 2017, 11:44 AM

Needs bitcode compatibility tests

tpr updated this revision to Diff 114974.Sep 12 2017, 11:25 PM

Added bitcode compatibility tests.

arsenm added inline comments.Sep 14 2017, 12:11 PM
test/Bitcode/compatibility.ll
479–480 ↗(On Diff #114974)

Missing the variants from the raw ccN

tpr marked an inline comment as done.Sep 15 2017, 2:18 AM
tpr added inline comments.
test/Bitcode/compatibility.ll
479–480 ↗(On Diff #114974)

Sorry, missed that I need to do that. I was wondering how it actually tests binary compatibility...

tpr updated this revision to Diff 115380.Sep 15 2017, 2:20 AM
tpr marked an inline comment as done.

Added more missing bitcode compatibility tests.

arsenm accepted this revision.Sep 15 2017, 9:34 AM

LGTM

This revision is now accepted and ready to land.Sep 15 2017, 9:34 AM
This revision was automatically updated to reflect the committed changes.