This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Fix typo when creating ISD::SUB nodes
ClosedPublic

Authored by rogfer01 on Sep 11 2017, 7:45 AM.

Details

Summary

In D35192, I accidentally introduced a typo when creating ISD::SUB nodes, giving them two values instead of one.

This fails when the merge_values combiner finds one of these nodes.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 created this revision.Sep 11 2017, 7:45 AM
efriedma accepted this revision.Sep 11 2017, 12:08 PM

LGTM, but please just use "MVT::i32" explicitly instead of "VT".

This revision is now accepted and ready to land.Sep 11 2017, 12:08 PM

This blunder of mine caused PR34564.

rogfer01 updated this revision to Diff 114768.Sep 12 2017, 12:35 AM

ChangeLog:

  • Use MVT::i32 instead of VT
This revision was automatically updated to reflect the committed changes.