This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Ensure that __lsan_is_turned_off isn't removed by DCE in llvm-tblgen
ClosedPublic

Authored by fjricci on Sep 8 2017, 11:59 AM.

Reviewers

Commits

Summary

Since asan is linked dynamically on Darwin, the weak interface symbol
is removed by -Wl,-dead_strip.

Build Status

Buildable 10032
Build 10032: arc lint + arc unit

alexander-shaposhnikov added inline comments.

utils/TableGen/TableGen.cpp
220	LLVM_ATTRIBUTE_USED ?

LLVM_ATTRIBUTE_USED

LGTM!

This revision is now accepted and ready to land.Sep 8 2017, 1:32 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

utils/

TableGen/

2 lines

Show First 20 Lines • Show All 211 Lines • ▼ Show 20 Lines	int main(int argc, char **argv) {
return TableGenMain(argv[0], &LLVMTableGenMain);		return TableGenMain(argv[0], &LLVMTableGenMain);
}		}

#ifdef __has_feature		#ifdef __has_feature
#if __has_feature(address_sanitizer)		#if __has_feature(address_sanitizer)
#include <sanitizer/lsan_interface.h>		#include <sanitizer/lsan_interface.h>
// Disable LeakSanitizer for this binary as it has too many leaks that are not		// Disable LeakSanitizer for this binary as it has too many leaks that are not
// very interesting to fix. See compiler-rt/include/sanitizer/lsan_interface.h .		// very interesting to fix. See compiler-rt/include/sanitizer/lsan_interface.h .
int __lsan_is_turned_off() { return 1; }		int __attribute__((__used__)) __lsan_is_turned_off() { return 1; }
		alexander-shaposhnikovUnsubmitted Not Done Reply Inline Actions LLVM_ATTRIBUTE_USED ? alexander-shaposhnikov: LLVM_ATTRIBUTE_USED ?
#endif // __has_feature(address_sanitizer)		#endif // __has_feature(address_sanitizer)
#endif // defined(__has_feature)		#endif // defined(__has_feature)