Page MenuHomePhabricator

AMDGPU: Start using !con operator
ClosedPublic

Authored by arsenm on Sep 7 2017, 2:37 PM.

Details

Summary

We have a lot of operand definition work essentially producing
every valid permutation of operands to workaround builiding
operand lists based on the instruction features. Apparently tablegen
already has a mostly undocumented operator to concat dags which
simplies this.

Convert one simple place to use this. The BUF instruction definitions
have much more complicated logic that can be totally rewritten now.

Diff Detail

Event Timeline

arsenm created this revision.Sep 7 2017, 2:37 PM
vpykhtin accepted this revision.Sep 8 2017, 7:34 AM

Wow! I wish I had this before! LGTM.

This revision is now accepted and ready to land.Sep 8 2017, 7:34 AM
SamWot accepted this revision.Sep 8 2017, 9:53 AM
arsenm closed this revision.Sep 8 2017, 12:10 PM

r312822