This is an archive of the discontinued LLVM Phabricator instance.

Differential D37588

[llvm-dlltool] Mention arm64 in the lists of architecture alternatives
ClosedPublic

Authored by mstorsjo on Sep 7 2017, 12:43 PM.

Details

Reviewers
ruiu
martell
Commits
rGd085200a114a: [llvm-dlltool] Mention arm64 in the lists of architecture alternatives
rL312776: [llvm-dlltool] Mention arm64 in the lists of architecture alternatives
Summary

This was missed in SVN r310223 when arm64 support was added.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 7 2017, 12:43 PM
Herald added subscribers: kristof.beyls, inglorion, mehdi_amini, aemerson. · View Herald TranscriptSep 7 2017, 12:43 PM
ruiu accepted this revision.Sep 7 2017, 12:50 PM

LGTM

This revision is now accepted and ready to land.Sep 7 2017, 12:50 PM
Closed by commit rL312776: [llvm-dlltool] Mention arm64 in the lists of architecture alternatives (authored by mstorsjo). · Explain WhySep 7 2017, 11:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
ToolDrivers/
llvm-dlltool/
4 lines

Diff 114306

llvm/trunk/lib/ToolDrivers/llvm-dlltool/DlltoolDriver.cpp

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines if (MissingCount) {
llvm::errs() << Args.getArgString(MissingIndex) << ": missing argument\n"; llvm::errs() << Args.getArgString(MissingIndex) << ": missing argument\n";
return 1; return 1;
} }
// Handle when no input or output is specified // Handle when no input or output is specified
if (Args.hasArgNoClaim(OPT_INPUT) || if (Args.hasArgNoClaim(OPT_INPUT) ||
(!Args.hasArgNoClaim(OPT_d) && !Args.hasArgNoClaim(OPT_l))) { (!Args.hasArgNoClaim(OPT_d) && !Args.hasArgNoClaim(OPT_l))) {
Table.PrintHelp(outs(), ArgsArr[0], "dlltool", false); Table.PrintHelp(outs(), ArgsArr[0], "dlltool", false);
llvm::outs() << "\nTARGETS: i386, i386:x86-64, arm\n"; llvm::outs() << "\nTARGETS: i386, i386:x86-64, arm, arm64\n";
return 1; return 1;
} }
if (!Args.hasArgNoClaim(OPT_m) && Args.hasArgNoClaim(OPT_d)) { if (!Args.hasArgNoClaim(OPT_m) && Args.hasArgNoClaim(OPT_d)) {
llvm::errs() << "error: no target machine specified\n" llvm::errs() << "error: no target machine specified\n"
<< "supported targets: i386, i386:x86-64, arm\n"; << "supported targets: i386, i386:x86-64, arm, arm64\n";
return 1; return 1;
} }
for (auto *Arg : Args.filtered(OPT_UNKNOWN)) for (auto *Arg : Args.filtered(OPT_UNKNOWN))
llvm::errs() << "ignoring unknown argument: " << Arg->getSpelling() << "\n"; llvm::errs() << "ignoring unknown argument: " << Arg->getSpelling() << "\n";
if (!Args.hasArg(OPT_d)) { if (!Args.hasArg(OPT_d)) {
llvm::errs() << "no definition file specified\n"; llvm::errs() << "no definition file specified\n";
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines