This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Cleanup decorators
ClosedPublic

Authored by vitalybuka on Sep 6 2017, 6:38 PM.

Details

Summary

Removed redundant End*() methods which defined same way.
Removed redundant Warning() methods.

Event Timeline

vitalybuka created this revision.Sep 6 2017, 6:38 PM
alekseyshl edited edge metadata.Sep 8 2017, 11:16 AM

What's the point of this change? It used to be generic, now it is more limiting. Even if we go this way, wouldn't it be more logical to drop End() altogether and use Default() directly? The code will make more sense.

End() -> Default()

eugenis accepted this revision.Sep 11 2017, 1:33 PM

I like it. Decorators affect output that follows them, so End* are pointless.

I assume Warning() must be common because it will be used in the common part of error reporting?

This revision is now accepted and ready to land.Sep 11 2017, 1:33 PM
alekseyshl accepted this revision.Sep 11 2017, 1:36 PM

I assume Warning() must be common because it will be used in the common part of error reporting?

Yes.

This revision was automatically updated to reflect the committed changes.