This is an archive of the discontinued LLVM Phabricator instance.

Differential D37537

[compiler-rt] Move allow_user_segv.cc into sanitizer_common
ClosedPublic

Authored by vitalybuka on Sep 6 2017, 3:35 PM.

Details

Reviewers
eugenis
alekseyshl
Commits
rGb4f2d13dc68a: [compiler-rt] Move allow_user_segv.cc into sanitizer_common
rCRT312859: [compiler-rt] Move allow_user_segv.cc into sanitizer_common
rL312859: [compiler-rt] Move allow_user_segv.cc into sanitizer_common
Summary

Part of https://github.com/google/sanitizers/issues/637

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka created this revision.Sep 6 2017, 3:35 PM
Herald added subscribers: dberris, kubamracek. · View Herald TranscriptSep 6 2017, 3:35 PM
vitalybuka updated this revision to Diff 114087.Sep 6 2017, 3:39 PM

Comment

Harbormaster completed remote builds in B9948: Diff 114087.Sep 6 2017, 3:39 PM
vitalybuka updated this revision to Diff 114090.Sep 6 2017, 3:48 PM

Removed feature

Harbormaster completed remote builds in B9950: Diff 114090.Sep 6 2017, 3:48 PM
vitalybuka added a reviewer: alekseyshl.Sep 7 2017, 5:39 PM
alekseyshl accepted this revision.Sep 8 2017, 10:52 AM
This revision is now accepted and ready to land.Sep 8 2017, 10:52 AM
Closed by commit rL312859: [compiler-rt] Move allow_user_segv.cc into sanitizer_common (authored by vitalybuka). · Explain WhySep 8 2017, 11:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
TestCases/
Posix/
87 lines
sanitizer_common/
TestCases/
Linux/
92 lines

Diff 114472

compiler-rt/trunk/test/asan/TestCases/Posix/allow_user_segv.cc

// Regression test for
// https://code.google.com/p/address-sanitizer/issues/detail?id=180
// clang-format off
// RUN: %clangxx_asan -O0 %s -o %t
// RUN: %env_asan_opts=handle_segv=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
// RUN: %env_asan_opts=handle_segv=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1
// RUN: %env_asan_opts=handle_segv=2 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// RUN: %env_asan_opts=handle_segv=0:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
// RUN: %env_asan_opts=handle_segv=1:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// RUN: %env_asan_opts=handle_segv=2:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// RUN: %env_asan_opts=handle_segv=0:allow_user_segv_handler=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
// RUN: %env_asan_opts=handle_segv=1:allow_user_segv_handler=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1
// RUN: %env_asan_opts=handle_segv=2:allow_user_segv_handler=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// clang-format on
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
struct sigaction original_sigaction_sigbus;
struct sigaction original_sigaction_sigsegv;
void User_OnSIGSEGV(int signum, siginfo_t *siginfo, void *context) {
fprintf(stderr, "User sigaction called\n");
struct sigaction original_sigaction;
if (signum == SIGBUS)
original_sigaction = original_sigaction_sigbus;
else if (signum == SIGSEGV)
original_sigaction = original_sigaction_sigsegv;
else {
printf("Invalid signum");
exit(1);
}
if (original_sigaction.sa_flags | SA_SIGINFO) {
if (original_sigaction.sa_sigaction)
original_sigaction.sa_sigaction(signum, siginfo, context);
} else {
if (original_sigaction.sa_handler)
original_sigaction.sa_handler(signum);
}
exit(1);
}
int DoSEGV() {
volatile int *x = 0;
return *x;
}
bool InstallHandler(int signum, struct sigaction *original_sigaction) {
struct sigaction user_sigaction;
user_sigaction.sa_sigaction = User_OnSIGSEGV;
user_sigaction.sa_flags = SA_SIGINFO;
if (sigaction(signum, &user_sigaction, original_sigaction)) {
perror("sigaction");
return false;
}
return true;
}
int main() {
// Let's install handlers for both SIGSEGV and SIGBUS, since pre-Yosemite
// 32-bit Darwin triggers SIGBUS instead.
if (InstallHandler(SIGSEGV, &original_sigaction_sigsegv) &&
InstallHandler(SIGBUS, &original_sigaction_sigbus)) {
fprintf(stderr, "User sigaction installed\n");
}
return DoSEGV();
}
// CHECK0-NOT: AddressSanitizer:DEADLYSIGNAL
// CHECK0-NOT: AddressSanitizer: SEGV on unknown address
// CHECK0: User sigaction installed
// CHECK0-NEXT: User sigaction called
// CHECK1: User sigaction installed
// CHECK1-NEXT: User sigaction called
// CHECK1-NEXT: AddressSanitizer:DEADLYSIGNAL
// CHECK1: AddressSanitizer: SEGV on unknown address
// CHECK2-NOT: User sigaction called
// CHECK2: User sigaction installed
// CHECK2-NEXT: AddressSanitizer:DEADLYSIGNAL
// CHECK2: AddressSanitizer: SEGV on unknown address

compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/allow_user_segv.cc

// Regression test for
// https://code.google.com/p/address-sanitizer/issues/detail?id=180
// clang-format off
// RUN: %clangxx -O0 %s -o %t
// RUN: %env_tool_opts=handle_segv=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
// RUN: %env_tool_opts=handle_segv=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1
// RUN: %env_tool_opts=handle_segv=2 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// RUN: %env_tool_opts=handle_segv=0:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
// RUN: %env_tool_opts=handle_segv=1:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// RUN: %env_tool_opts=handle_segv=2:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// RUN: %env_tool_opts=handle_segv=0:allow_user_segv_handler=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
// RUN: %env_tool_opts=handle_segv=1:allow_user_segv_handler=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1
// RUN: %env_tool_opts=handle_segv=2:allow_user_segv_handler=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
// clang-format on
// Remove when fixed: https://github.com/google/sanitizers/issues/637
// UNSUPPORTED: lsan
// UNSUPPORTED: msan
// UNSUPPORTED: tsan
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
struct sigaction original_sigaction_sigbus;
struct sigaction original_sigaction_sigsegv;
void User_OnSIGSEGV(int signum, siginfo_t *siginfo, void *context) {
fprintf(stderr, "User sigaction called\n");
struct sigaction original_sigaction;
if (signum == SIGBUS)
original_sigaction = original_sigaction_sigbus;
else if (signum == SIGSEGV)
original_sigaction = original_sigaction_sigsegv;
else {
printf("Invalid signum");
exit(1);
}
if (original_sigaction.sa_flags | SA_SIGINFO) {
if (original_sigaction.sa_sigaction)
original_sigaction.sa_sigaction(signum, siginfo, context);
} else {
if (original_sigaction.sa_handler)
original_sigaction.sa_handler(signum);
}
exit(1);
}
int DoSEGV() {
volatile int *x = 0;
return *x;
}
bool InstallHandler(int signum, struct sigaction *original_sigaction) {
struct sigaction user_sigaction;
user_sigaction.sa_sigaction = User_OnSIGSEGV;
user_sigaction.sa_flags = SA_SIGINFO;
if (sigaction(signum, &user_sigaction, original_sigaction)) {
perror("sigaction");
return false;
}
return true;
}
int main() {
// Let's install handlers for both SIGSEGV and SIGBUS, since pre-Yosemite
// 32-bit Darwin triggers SIGBUS instead.
if (InstallHandler(SIGSEGV, &original_sigaction_sigsegv) &&
InstallHandler(SIGBUS, &original_sigaction_sigbus)) {
fprintf(stderr, "User sigaction installed\n");
}
return DoSEGV();
}
// CHECK0-NOT: AddressSanitizer:DEADLYSIGNAL
// CHECK0-NOT: AddressSanitizer: SEGV on unknown address
// CHECK0: User sigaction installed
// CHECK0-NEXT: User sigaction called
// CHECK1: User sigaction installed
// CHECK1-NEXT: User sigaction called
// CHECK1-NEXT: AddressSanitizer:DEADLYSIGNAL
// CHECK1: AddressSanitizer: SEGV on unknown address
// CHECK2-NOT: User sigaction called
// CHECK2: User sigaction installed
// CHECK2-NEXT: AddressSanitizer:DEADLYSIGNAL
// CHECK2: AddressSanitizer: SEGV on unknown address