This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Start selecting v_mad_mix_f32
ClosedPublic

Authored by arsenm on Aug 28 2017, 10:51 AM.

Details

Reviewers
rampitec
kzhuravl

Diff Detail

Event Timeline

arsenm created this revision.Aug 28 2017, 10:51 AM
rampitec added inline comments.Aug 28 2017, 5:06 PM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
1671

What practical sense does it have, if we default to support f32 denorms on GFX9 and have no such instructions before?

arsenm added inline comments.Aug 28 2017, 5:20 PM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
1671

Graphics still disables f32 denormals

arsenm added inline comments.Aug 28 2017, 5:21 PM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
1671

Also the TODO is for the case where we can use this with denormals enabled.

rampitec added inline comments.Aug 28 2017, 5:27 PM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
1671

OK. What prevents FMAD from being selected if denorms are supported?

arsenm added inline comments.Aug 28 2017, 5:27 PM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
1671

We should also probably bring back the less-precise-fpmad option. That would also probably make this valid to use

This revision is now accepted and ready to land.Aug 29 2017, 12:20 PM
arsenm closed this revision.Sep 7 2017, 11:06 AM

r312732