This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Select clamp pattern with v2f16
ClosedPublic

Authored by arsenm on Aug 25 2017, 11:29 AM.

Details

Reviewers
rampitec
kzhuravl

Diff Detail

Event Timeline

arsenm created this revision.Aug 25 2017, 11:29 AM
rampitec added inline comments.Aug 29 2017, 12:32 PM
lib/Target/AMDGPU/SIISelLowering.cpp
5687

Why did you change it from early return?

arsenm added inline comments.Aug 29 2017, 12:59 PM
lib/Target/AMDGPU/SIISelLowering.cpp
5687

The inverted condition got more complicated and harder to read

This revision is now accepted and ready to land.Aug 29 2017, 1:07 PM
arsenm closed this revision.Aug 29 2017, 6:21 PM

r312087