This is an archive of the discontinued LLVM Phabricator instance.

[polly] Fix ScopDetectionDiagnostic test failure caused by r310940
ClosedPublic

Authored by kuhar on Aug 15 2017, 4:50 PM.

Details

Summary

ScopDetection used to check if a loop withing a region was infinite and emitted a diagnostic in such cases. After r310940 there's no point checking against that situation, as infinite loops don't appear in regions anymore.

The test failure was observed on these two polly buildbots:
http://lab.llvm.org:8011/builders/polly-arm-linux/builds/8368
http://lab.llvm.org:8011/builders/polly-amd64-linux/builds/10310

This patch XFAILs ReportLoopHasNoExit.ll and turns infinite loop detection into an assert.

Diff Detail

Repository
rL LLVM

Event Timeline

kuhar created this revision.Aug 15 2017, 4:50 PM

Please merge the change to XFAIL the test immediately, so the tree isn't broken.

The cleanup doesn't seem complete; you should be able to get rid of ReportLoopHasNoExit entirely.

kuhar added a comment.Aug 15 2017, 5:20 PM

I XFAILed the test in r310980.

kuhar updated this revision to Diff 111293.Aug 15 2017, 5:37 PM

Remove ReportLoopHasNoExit, as @efriedma suggested.

Ping. This is still not fixed upstream.

grosser edited edge metadata.Aug 22 2017, 1:47 PM

OK for now. I would like to get these back at some point, but should do this later.

test/ScopDetectionDiagnostics/ReportLoopHasNoExit.ll
4 ↗(On Diff #111293)

The "ony" seems brokenhere.

grosser accepted this revision.Aug 22 2017, 1:48 PM

Forgot the LGTM. Thanks for cleaning Polly as well.

This revision is now accepted and ready to land.Aug 22 2017, 1:48 PM
kuhar added a comment.Aug 22 2017, 1:58 PM

Just wanted to make sure this doesn't get forgotten :).

OK for now. I would like to get these back at some point, but should do this later.

Just to be clear -- would you prefer to commit it yourself, or is this LGTM a green light for me?

Thanks. The LGTM is the green light. Go ahead and commit. Thanks for asking, but for now this change is almost obvious.

kuhar updated this revision to Diff 112234.Aug 22 2017, 2:58 PM

Fix typo in the comment.

kuhar marked an inline comment as done.Aug 22 2017, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Looks like this is causing failures on the polly aosp bot (http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/228). I'll try to come up with a testcase soon.