Page MenuHomePhabricator

[ARM] Clarify legal addressing modes for ARM and Thumb2. NFC
ClosedPublic

Authored by efriedma on Aug 9 2017, 4:38 PM.

Details

Summary

The existing code is very clever, but not clear, which seems like the wrong tradeoff here.

Diff Detail

Repository
rL LLVM

Event Timeline

efriedma created this revision.Aug 9 2017, 4:38 PM
fhahn added a subscriber: fhahn.Aug 10 2017, 1:46 AM
fhahn added a comment.Aug 10 2017, 1:51 AM

Looks like a straightforward NFC that makes the code clearer. LGTM, but maybe someone else should have a quick look too.

eastig accepted this revision.Aug 10 2017, 5:40 AM

LGTM

lib/Target/ARM/ARMISelLowering.cpp
12366 ↗(On Diff #110500)

Agree, this code needs to be reviewed. LDRD has tricky addressing modes for both ARM and T2 modes.

This revision is now accepted and ready to land.Aug 10 2017, 5:40 AM
This revision was automatically updated to reflect the committed changes.