This is an archive of the discontinued LLVM Phabricator instance.

Differential D36490

Enable ASAN on NetBSD
ClosedPublic

Authored by krytarowski on Aug 8 2017, 2:43 PM.

Details

Reviewers
joerg
vitalybuka
filcab
kcc
fjricci
Commits
rG7a6b68062242: Enable ASAN on NetBSD
rCRT310651: Enable ASAN on NetBSD
rL310651: Enable ASAN on NetBSD
Summary

This enables also static runtime option.

Sponsored by <The NetBSD Foundation>

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Aug 8 2017, 2:43 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 8 2017, 2:43 PM
krytarowski added a comment.Aug 8 2017, 5:58 PM

check-asan

Failing Tests (2):
    AddressSanitizer-Unit :: ./Asan-x86_64-inline-Test/AddressSanitizerInterface.ManyThreadsWithStatsStressTest
    AddressSanitizer-Unit :: ./Asan-x86_64-with-calls-Test/AddressSanitizerInterface.ManyThreadsWithStatsStressTest

  Expected Passes    : 436
  Unsupported Tests  : 814
  Unexpected Failures: 2

check-asan-dynamic

Failing Tests (2):
    AddressSanitizer-Unit :: ./Asan-x86_64-inline-Dynamic-Test/AddressSanitizerInterface.ManyThreadsWithStatsStressTest
    AddressSanitizer-Unit :: ./Asan-x86_64-with-calls-Dynamic-Test/AddressSanitizerInterface.ManyThreadsWithStatsStressTest

  Expected Passes    : 372
  Unsupported Tests  : 814
  Unexpected Failures: 2

I will focus on these failures later.

vitalybuka added inline comments.Aug 10 2017, 11:32 AM
cmake/config-ix.cmake
487

No sure what does this mean: COMPILER_RT_ASAN_HAS_STATIC_RUNTIME and no COMPILER_RT_HAS_ASAN

krytarowski added inline comments.Aug 10 2017, 11:39 AM
cmake/config-ix.cmake
487

This enables COMPILER_RT_HAS_ASAN and COMPILER_RT_ASAN_HAS_STATIC_RUNTIME on NetBSD.

vitalybuka added inline comments.Aug 10 2017, 11:41 AM
cmake/config-ix.cmake
487

But there is NOT OS_NAME MATCHES "NetBSD"

krytarowski added inline comments.Aug 10 2017, 11:43 AM
cmake/config-ix.cmake
487

This is correct.

vitalybuka added inline comments.Aug 10 2017, 11:47 AM
cmake/config-ix.cmake
487

So I read this as NetBSD will always have COMPILER_RT_HAS_ASAN equal FALSE.
How does this enable COMPILER_RT_HAS_ASAN?

krytarowski added inline comments.Aug 10 2017, 11:49 AM
cmake/config-ix.cmake
487

This patch removes this line, not adds it. With removal of this condition (NOT NETBSD), it enables COMPILER_RT_HAS_ASAN.

vitalybuka accepted this revision.Aug 10 2017, 12:00 PM
vitalybuka added inline comments.
cmake/config-ix.cmake
487

facepalm
thanks

This revision is now accepted and ready to land.Aug 10 2017, 12:00 PM
krytarowski closed this revision.Aug 10 2017, 12:09 PM

Revision Contents

PathSize
cmake/
5 lines

Diff 110283

cmake/config-ix.cmake

Show First 20 Lines • Show All 477 Lines • ▼ Show 20 Lines
endif() endif()
if (COMPILER_RT_HAS_SANITIZER_COMMON) if (COMPILER_RT_HAS_SANITIZER_COMMON)
set(COMPILER_RT_HAS_INTERCEPTION TRUE) set(COMPILER_RT_HAS_INTERCEPTION TRUE)
else() else()
set(COMPILER_RT_HAS_INTERCEPTION FALSE) set(COMPILER_RT_HAS_INTERCEPTION FALSE)
endif() endif()
if (COMPILER_RT_HAS_SANITIZER_COMMON AND ASAN_SUPPORTED_ARCH AND if (COMPILER_RT_HAS_SANITIZER_COMMON AND ASAN_SUPPORTED_ARCH)
(NOT OS_NAME MATCHES "NetBSD"))
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

No sure what does this mean: COMPILER_RT_ASAN_HAS_STATIC_RUNTIME and no COMPILER_RT_HAS_ASAN

vitalybuka: No sure what does this mean: COMPILER_RT_ASAN_HAS_STATIC_RUNTIME and no COMPILER_RT_HAS_ASAN
krytarowskiAuthorUnsubmitted
Not Done
ReplyInline Actions

This enables COMPILER_RT_HAS_ASAN and COMPILER_RT_ASAN_HAS_STATIC_RUNTIME on NetBSD.

krytarowski: This enables COMPILER_RT_HAS_ASAN and COMPILER_RT_ASAN_HAS_STATIC_RUNTIME on NetBSD.
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

But there is NOT OS_NAME MATCHES "NetBSD"

vitalybuka: But there is **NOT** OS_NAME MATCHES "NetBSD"
krytarowskiAuthorUnsubmitted
Not Done
ReplyInline Actions

This is correct.

krytarowski: This is correct.
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

So I read this as NetBSD will always have COMPILER_RT_HAS_ASAN equal FALSE.
How does this enable COMPILER_RT_HAS_ASAN?

vitalybuka: So I read this as NetBSD will always have COMPILER_RT_HAS_ASAN equal FALSE. How does this…
krytarowskiAuthorUnsubmitted
Not Done
ReplyInline Actions

This patch removes this line, not adds it. With removal of this condition (NOT NETBSD), it enables COMPILER_RT_HAS_ASAN.

krytarowski: This patch removes this line, not adds it. With removal of this condition (NOT NETBSD), it…
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

facepalm
thanks

vitalybuka: facepalm thanks
set(COMPILER_RT_HAS_ASAN TRUE) set(COMPILER_RT_HAS_ASAN TRUE)
else() else()
set(COMPILER_RT_HAS_ASAN FALSE) set(COMPILER_RT_HAS_ASAN FALSE)
endif() endif()
if (OS_NAME MATCHES "Linux|FreeBSD|Windows") if (OS_NAME MATCHES "Linux|FreeBSD|Windows|NetBSD")
set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME TRUE) set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME TRUE)
else() else()
set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME FALSE) set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME FALSE)
endif() endif()
# TODO: Add builtins support. # TODO: Add builtins support.
if (COMPILER_RT_HAS_SANITIZER_COMMON AND DFSAN_SUPPORTED_ARCH AND if (COMPILER_RT_HAS_SANITIZER_COMMON AND DFSAN_SUPPORTED_ARCH AND
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines