This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] 'implicit cast' -> 'implicit conversion'
ClosedPublic

Authored by alexfh on Aug 8 2017, 3:27 AM.

Details

Summary

This patch renames checks, check options and changes messages to use correct
term "implicit conversion" instead of "implicit cast" (which has been in use in
Clang AST since ~10 years, but it's still technically incorrect w.r.t. C++
standard).

  • performance-implicit-cast-in-loop -> performance-implicit-conversion-in-loop
  • readability-implicit-bool-cast -> readability-implicit-bool-conversion
    • readability-implicit-bool-cast.AllowConditionalIntegerCasts -> readability-implicit-bool-conversion.AllowIntegerConditions
    • readability-implicit-bool-cast.AllowConditionalPointerCasts -> readability-implicit-bool-conversion.AllowPointerConditions

Diff Detail

Repository
rL LLVM

Event Timeline

alexfh created this revision.Aug 8 2017, 3:27 AM
alexfh updated this revision to Diff 110166.Aug 8 2017, 3:36 AM

Added redirections from the old check documents.

hokein accepted this revision.Aug 8 2017, 4:45 AM

LGTM.

This revision is now accepted and ready to land.Aug 8 2017, 4:45 AM
This revision was automatically updated to reflect the committed changes.
clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast-cxx98.cpp