[CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared

[iid_iunknown]

Summary

The LLVM${c}Info mask is listed twice in LLVM-Config.cmake. This results in the libraries such as LLVMARMInfo, LLVMAArch4Info, etc appearing twice in extract_symbols.py command line while building clangShared. Extract_symbols.py does not work well in such a case and completely ignores the symbols from the duplicated libraries. Thus, the LLVM(...)Info symbols do not get exported from clangShared and linking clang against it fails with unresolved dependencies.

Seems to be a mere copy-paste mistake.

[chapuni]

I think matchers may be sorted alphabetically.

cmake/modules/LLVM-Config.cmake

188 ↗

(On Diff #109006)

Could we remove it?

[chapuni]

Excuse me, I supposed to cancel "Accept". At first, I looked into it and thought LGTM.

[iid_iunknown]

Yes, keeping them sorted is a good idea. I will update the patch.
Thanks!

[iid_iunknown]

Sort the matchers

[chapuni]

Thanks!

[iid_iunknown]

Thanks for the review!

llvm/trunk/cmake/modules/LLVM-Config.cmake

if( NOT idx LESS 0 )
         list(APPEND expanded_components "LLVM${c}CodeGen")
       else()
         if( TARGET LLVM${c} )
           list(APPEND expanded_components "LLVM${c}")
         else()
           message(FATAL_ERROR "Target ${c} is not in the set of libraries.")
         endif()
       endif()
-      if( TARGET LLVM${c}AsmPrinter )
-        list(APPEND expanded_components "LLVM${c}AsmPrinter")
-      endif()
       if( TARGET LLVM${c}AsmParser )
         list(APPEND expanded_components "LLVM${c}AsmParser")
       endif()
+      if( TARGET LLVM${c}AsmPrinter )
+        list(APPEND expanded_components "LLVM${c}AsmPrinter")
+      endif()
       if( TARGET LLVM${c}Desc )
         list(APPEND expanded_components "LLVM${c}Desc")
       endif()
-      if( TARGET LLVM${c}Info )
-        list(APPEND expanded_components "LLVM${c}Info")
-      endif()
       if( TARGET LLVM${c}Disassembler )
         list(APPEND expanded_components "LLVM${c}Disassembler")
       endif()
       if( TARGET LLVM${c}Info )
         list(APPEND expanded_components "LLVM${c}Info")
       endif()
       if( TARGET LLVM${c}Utils )
         list(APPEND expanded_components "LLVM${c}Utils")