Page MenuHomePhabricator

iid_iunknown (Oleg Ranevskyy)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 4:10 AM (270 w, 4 d)

Recent Activity

Oct 31 2017

iid_iunknown closed D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.
Oct 31 2017, 6:51 AM · lld
iid_iunknown updated the diff for D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.

Use Optional in getArchiveName()

Oct 31 2017, 6:44 AM · lld
iid_iunknown added inline comments to D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.
Oct 31 2017, 6:42 AM · lld

Oct 27 2017

iid_iunknown added inline comments to D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.
Oct 27 2017, 4:21 AM · lld

Oct 26 2017

iid_iunknown added inline comments to D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.
Oct 26 2017, 5:20 PM · lld
iid_iunknown updated the diff for D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.

Introducing getArchiveName

Oct 26 2017, 5:15 PM · lld
iid_iunknown created D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.
Oct 26 2017, 4:24 PM · lld

Oct 9 2017

iid_iunknown added a comment to D37398: [Support, Windows] Retry rename() when MoveFileExW returns ERROR_SHARING_VIOLATION.

A gentle reminder about this patch.

Oct 9 2017, 12:43 PM

Sep 6 2017

iid_iunknown created D37521: [Sema][Typo correction] Assertion failure in typo correction if chain of member function calls has multiple typos.
Sep 6 2017, 9:39 AM

Sep 1 2017

iid_iunknown created D37398: [Support, Windows] Retry rename() when MoveFileExW returns ERROR_SHARING_VIOLATION.
Sep 1 2017, 1:55 PM

Aug 31 2017

iid_iunknown closed D37336: [clang-cl] Explicitly set object format to COFF in CL mode.
Aug 31 2017, 1:32 PM
iid_iunknown added a comment to D37336: [clang-cl] Explicitly set object format to COFF in CL mode.

Thanks for reviewing this!

Aug 31 2017, 1:31 PM
iid_iunknown added a comment to D37336: [clang-cl] Explicitly set object format to COFF in CL mode.

Do you think you can write a test for your patch that will work on the buildbots we have?

I am afraid, this is not possible with the existing buildbots. --target does not affect the default triple. There is LLVM_TARGET_TRIPLE_ENV that allows to override the default triple at runtime, but LLVM must be configured to support it and none of the Windows buildbots do this. I see no other way to implement such a test, unfortunately.

Aug 31 2017, 11:50 AM
iid_iunknown added a comment to D37336: [clang-cl] Explicitly set object format to COFF in CL mode.
In D37336#857802, @hans wrote:

But why isn't that failure showing on some buildbot, then?

The test needs system-windows to run:

// REQUIRES: system-windows

There is no windows buildbot that builds clang defaulted to the AArch64 target.

Aug 31 2017, 9:07 AM
iid_iunknown created D37336: [clang-cl] Explicitly set object format to COFF in CL mode.
Aug 31 2017, 7:59 AM

Aug 23 2017

iid_iunknown added a comment to D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.

Peter, Anton,
Thank you very much for helping with this!

Aug 23 2017, 7:27 AM
iid_iunknown closed D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.
Aug 23 2017, 7:27 AM

Aug 22 2017

iid_iunknown added a comment to D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.

Hi Peter,

Aug 22 2017, 4:39 PM

Aug 15 2017

iid_iunknown added a comment to D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.

I'll need to work out why my target (default armv7--linux-gnueabihf) got rejected. As an aside it would be interesting to know what target you used?

Yes, I had to manually add arm-target-arch to available features to enable these tests.
Seems we can fix this by handling the ARM architectures similarly to x86 (test/lit.common.cfg):

if target_arch in ['x86_64', 'i386', 'i686']:
  config.available_features.add('x86-target-arch')

For ARM we now have only

config.available_features.add(target_arch + '-target-arch')

so the armv7--linux-gnueabihf triple gives us armv7-target-arch that does not match the test's requirements.

Aug 15 2017, 4:16 PM

Aug 14 2017

iid_iunknown updated the diff for D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.

Address review remarks: make the macro names less generic.

Aug 14 2017, 5:11 PM
iid_iunknown added a comment to D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.

Thanks for the feedback, Peter!

Aug 14 2017, 5:08 PM
iid_iunknown created D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.
Aug 14 2017, 6:26 AM

Aug 10 2017

iid_iunknown added a comment to D36119: [CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared.

Thanks for the review!

Aug 10 2017, 6:38 AM
iid_iunknown added a comment to D35336: [compiler-rt][ARM] Fix filtering of ARM targets.

Thanks for reviewing this, Saleem!

Aug 10 2017, 6:30 AM
iid_iunknown closed D35336: [compiler-rt][ARM] Fix filtering of ARM targets.
Aug 10 2017, 6:28 AM

Aug 1 2017

iid_iunknown updated the diff for D36119: [CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared.

Sort the matchers

Aug 1 2017, 11:39 AM
iid_iunknown added a comment to D36119: [CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared.

Yes, keeping them sorted is a good idea. I will update the patch.
Thanks!

Aug 1 2017, 11:30 AM

Jul 31 2017

iid_iunknown created D36119: [CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared.
Jul 31 2017, 3:33 PM

Jul 12 2017

iid_iunknown created D35336: [compiler-rt][ARM] Fix filtering of ARM targets.
Jul 12 2017, 4:27 PM

Jul 10 2017

iid_iunknown added a comment to D34430: [Clang][TypoCorrection] Clang hangs in typo correction.

A gentle reminder about this patch.

Jul 10 2017, 7:28 AM · Restricted Project

Jun 21 2017

iid_iunknown added a reviewer for D34430: [Clang][TypoCorrection] Clang hangs in typo correction: rsmith.
Jun 21 2017, 7:33 AM · Restricted Project
iid_iunknown added a comment to D34430: [Clang][TypoCorrection] Clang hangs in typo correction.

No hang with this patch on the test case from PR33484. Clang reports a number of expected compilation errors instead.

Jun 21 2017, 7:32 AM · Restricted Project

Jun 20 2017

iid_iunknown updated the diff for D34430: [Clang][TypoCorrection] Clang hangs in typo correction.

Fixed white spaces.

Jun 20 2017, 5:05 PM · Restricted Project
iid_iunknown created D34430: [Clang][TypoCorrection] Clang hangs in typo correction.
Jun 20 2017, 5:00 PM · Restricted Project

May 23 2017

iid_iunknown added a comment to D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

Eli, James, thanks for the review!

May 23 2017, 12:39 PM
iid_iunknown closed D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.
May 23 2017, 12:38 PM
iid_iunknown added a comment to D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

Updated the patch.

May 23 2017, 11:57 AM
iid_iunknown updated the diff for D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

Addressing the review comments.

May 23 2017, 11:57 AM
iid_iunknown added a comment to D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

I would suggest switching the option (arm-promote-constant) to default to false rather than commenting out the code, so we don't have to XFAIL the unit-tests.

Thanks for your comment, Eli.

May 23 2017, 11:05 AM
iid_iunknown added a comment to D32567: [ARM] Miscompilation on arrays promoted to constant pools.

As this patch has not been accepted and 4.0.1 is apporaching, and taking into account the severity level of the problem, another patch is suggested to temporarily disable globals promotion:

May 23 2017, 9:13 AM
iid_iunknown created D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.
May 23 2017, 9:11 AM

Apr 26 2017

iid_iunknown created D32567: [ARM] Miscompilation on arrays promoted to constant pools.
Apr 26 2017, 3:49 PM

Jan 26 2017

iid_iunknown closed D28908: [Compiler-rt] Broken compiler-rt CMake configuring on Windows.
Jan 26 2017, 10:27 AM
iid_iunknown added a comment to D28908: [Compiler-rt] Broken compiler-rt CMake configuring on Windows.

Well, it doesn't seem to break anything for me on Linux and it resembles the code below, so I guess it's good to go.

Jan 26 2017, 10:26 AM

Jan 19 2017

iid_iunknown created D28908: [Compiler-rt] Broken compiler-rt CMake configuring on Windows.
Jan 19 2017, 9:32 AM

Dec 28 2016

iid_iunknown abandoned D9744: Install libunwind headers.
Dec 28 2016, 6:00 AM
iid_iunknown abandoned D16901: [Clang driver, ARM] Do not add +long-calls in PIC mode.

Abandoning the patch as it is too old.

Dec 28 2016, 5:55 AM
iid_iunknown abandoned D8880: [libcxx] std::codecvt - short wchar support.

Abandoning the patch as it is too old.

Dec 28 2016, 5:51 AM
iid_iunknown abandoned D6298: LLVM Test-suite: LNT fixes for better Windows support.
Dec 28 2016, 5:48 AM
iid_iunknown abandoned D6460: LLVM test-suite: tools/timeit port to Windows.
Dec 28 2016, 5:47 AM
iid_iunknown abandoned D6483: Test-suite: the spiff test fails if the suite repo is cloned on Windows due to the wrong EOL property on the reference output file..
Dec 28 2016, 5:47 AM
iid_iunknown abandoned D24941: [libc++][tests] Fixing some issues in unordered container tests.
Dec 28 2016, 5:45 AM

Dec 22 2016

iid_iunknown added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

@rSerge You forgot to add a forward declaration for __clear_cache to make it visible like e.g. trampoline_setup.c does.

Dec 22 2016, 12:28 PM

Dec 1 2016

iid_iunknown closed D27315: [ARM] Fix for 64-bit CAS expansion on ARM32 with -O0.
Dec 1 2016, 3:08 PM
iid_iunknown added inline comments to D27315: [ARM] Fix for 64-bit CAS expansion on ARM32 with -O0.
Dec 1 2016, 3:05 PM
iid_iunknown updated the diff for D27315: [ARM] Fix for 64-bit CAS expansion on ARM32 with -O0.

Addressing the review remarks.

Dec 1 2016, 3:01 PM
iid_iunknown retitled D27315: [ARM] Fix for 64-bit CAS expansion on ARM32 with -O0 from to [ARM] Fix for 64-bit CAS expansion on ARM32 with -O0.
Dec 1 2016, 11:56 AM

Nov 18 2016

iid_iunknown closed D26464: [ARM] Fix sema check of ARM special register names.
Nov 18 2016, 1:09 PM

Nov 15 2016

iid_iunknown added a comment to D26464: [ARM] Fix sema check of ARM special register names.

Looks like an oversight. Aren't there any tests for this? Maybe there should be one.

Nov 15 2016, 9:41 AM
iid_iunknown updated the diff for D26464: [ARM] Fix sema check of ARM special register names.

Tests extended to check for more corner cases.

Nov 15 2016, 9:41 AM
iid_iunknown updated the diff for D26464: [ARM] Fix sema check of ARM special register names.

Tests added.

Nov 15 2016, 9:30 AM

Nov 9 2016

iid_iunknown retitled D26464: [ARM] Fix sema check of ARM special register names from to [ARM] Fix sema check of ARM special register names.
Nov 9 2016, 10:28 AM

Oct 11 2016

iid_iunknown added a comment to D24941: [libc++][tests] Fixing some issues in unordered container tests.

This *almost* LGTM. The tests that have been converted to a throwing _LIBCPP_ASSERT need to be marked with // UNSUPPORTED: libcpp-no-exceptions

Yep, I was going to add UNSUPPORTED but accidentally missed them at the last moment.
Thanks for the reminder!

Oct 11 2016, 2:23 PM
iid_iunknown updated the diff for D24941: [libc++][tests] Fixing some issues in unordered container tests.

Addressing the review remarks.
"UNSUPPORTED: libcpp-no-exceptions" added.

Oct 11 2016, 2:21 PM

Sep 27 2016

iid_iunknown added inline comments to D24941: [libc++][tests] Fixing some issues in unordered container tests.
Sep 27 2016, 2:21 PM
iid_iunknown added a comment to D24941: [libc++][tests] Fixing some issues in unordered container tests.

Thanks for cleaning up our debug mode. I've added a couple of inline comments which need to be addressed.

Sep 27 2016, 2:19 PM
iid_iunknown updated the diff for D24941: [libc++][tests] Fixing some issues in unordered container tests.

Addressing the review remarks

Sep 27 2016, 2:13 PM

Sep 26 2016

iid_iunknown updated D24941: [libc++][tests] Fixing some issues in unordered container tests.
Sep 26 2016, 3:10 PM
iid_iunknown updated D24941: [libc++][tests] Fixing some issues in unordered container tests.
Sep 26 2016, 3:09 PM
iid_iunknown retitled D24941: [libc++][tests] Fixing some issues in unordered container tests from to [libc++][tests] Fixing some issues in unordered container tests.
Sep 26 2016, 3:07 PM
iid_iunknown closed D24883: [libc++] Fix typos causing compilation errors when _LIBCPP_DEBUG_LEVEL >= 2.
Sep 26 2016, 2:48 PM
iid_iunknown added a comment to D24883: [libc++] Fix typos causing compilation errors when _LIBCPP_DEBUG_LEVEL >= 2.

Thanks for reviewing this, Eric!

Sep 26 2016, 2:47 PM

Sep 23 2016

iid_iunknown retitled D24883: [libc++] Fix typos causing compilation errors when _LIBCPP_DEBUG_LEVEL >= 2 from to [libc++] Fix typos causing compilation errors when _LIBCPP_DEBUG_LEVEL >= 2.
Sep 23 2016, 1:45 PM

Aug 26 2016

iid_iunknown updated subscribers of D23933: [XRay] ARM 32-bit no-Thumb support in compiler-rt.
Aug 26 2016, 11:33 AM
iid_iunknown updated subscribers of D23932: [XRay] ARM 32-bit no-Thumb support in Clang.
Aug 26 2016, 11:33 AM
iid_iunknown updated subscribers of D23931: [XRay] ARM 32-bit no-Thumb support in LLVM.
Aug 26 2016, 11:31 AM

Aug 18 2016

iid_iunknown closed D23633: [compiler-rt][tests] cpu_model_test.c test fails to compile if X86 is not clang's default target.
Aug 18 2016, 7:47 AM
iid_iunknown added a comment to D23633: [compiler-rt][tests] cpu_model_test.c test fails to compile if X86 is not clang's default target.

Thank you for the review, Alina.

Aug 18 2016, 7:33 AM

Aug 17 2016

iid_iunknown retitled D23633: [compiler-rt][tests] cpu_model_test.c test fails to compile if X86 is not clang's default target from to [compiler-rt][tests] cpu_model_test.c test fails to compile if X86 is not clang's default target.
Aug 17 2016, 4:03 PM

May 25 2016

iid_iunknown closed D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".
May 25 2016, 6:07 AM

May 24 2016

iid_iunknown added a comment to D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".

Let me know if you need me to check this in for you.

May 24 2016, 4:10 PM
iid_iunknown updated the diff for D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".

Corrections according to the Sanjoy's comments

May 24 2016, 3:53 PM

May 23 2016

iid_iunknown updated the diff for D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".

Addressing the review comments from Sanjoy.

May 23 2016, 5:05 PM

May 22 2016

iid_iunknown added a comment to D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".

Could you elaborate on this part of your comment, please?

with `CHECK:` lines verifying that the `sext` instructions don't get mapped to `sext` SCEV expressions.
May 22 2016, 4:53 AM

May 13 2016

iid_iunknown added a comment to D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".
May 13 2016, 3:17 PM
iid_iunknown added a comment to D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".

This needs at least one test case (preferably more than one) demonstrating the motivation. A simplified form of the "Minimal reproducer:" will do.

May 13 2016, 3:16 PM
iid_iunknown updated the diff for D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".

Addressing the review comments.

May 13 2016, 3:15 PM
iid_iunknown closed D20219: [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF).
May 13 2016, 7:52 AM

May 12 2016

iid_iunknown retitled D20219: [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF) from to [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF).
May 12 2016, 12:53 PM

May 8 2016

iid_iunknown retitled D20058: [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}" from to [SCEV] No-wrap flags are not propagated when folding "{S,+,X}+T ==> {S+T,+,X}".
May 8 2016, 10:22 AM

Mar 30 2016

iid_iunknown closed D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.
Mar 30 2016, 2:35 PM
iid_iunknown added a comment to D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.

I have commit access.
Thank you for your help with the patch!

Mar 30 2016, 2:31 PM
iid_iunknown added inline comments to D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.
Mar 30 2016, 1:33 PM
iid_iunknown updated the diff for D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.

The test enabled for all targets.

Mar 30 2016, 1:32 PM
iid_iunknown added a comment to D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.

Thank you for your remark, Richard.
I added the test. Could you check if the patch is good now, please?

Mar 30 2016, 11:42 AM
iid_iunknown updated the diff for D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.

Test case added.

Mar 30 2016, 11:41 AM

Mar 29 2016

iid_iunknown added a reviewer for D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash: rsmith.
Mar 29 2016, 1:07 PM
iid_iunknown updated subscribers of D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.
Mar 29 2016, 12:57 PM
iid_iunknown retitled D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash from to [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash.
Mar 29 2016, 8:42 AM

Feb 4 2016

iid_iunknown retitled D16901: [Clang driver, ARM] Do not add +long-calls in PIC mode from to [Clang driver, ARM] Do not add +long-calls in PIC mode.
Feb 4 2016, 2:13 PM