This is an archive of the discontinued LLVM Phabricator instance.

Differential D36100

[Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well
ClosedPublic

Authored by mstorsjo on Jul 31 2017, 12:24 PM.

Details

Reviewers
rnk
mgrang
Commits
rGf3ed393d699a: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well
rC309620: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well
rL309620: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 31 2017, 12:24 PM
Herald added subscribers: kristof.beyls, rengolin, aemerson. · View Herald TranscriptJul 31 2017, 12:24 PM
rnk accepted this revision.Jul 31 2017, 12:38 PM

lgtm

This revision is now accepted and ready to land.Jul 31 2017, 12:38 PM
Closed by commit rL309620: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well (authored by mstorsjo). · Explain WhyJul 31 2017, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
clang/
Basic/
4 lines
test/
Sema/
1 line

Diff 108971

include/clang/Basic/Attr.td

Show First 20 Lines • Show All 262 Lines • ▼ Show 20 Linesclass TargetArch<list<string> arches> {
list<string> CXXABIs; list<string> CXXABIs;
} }
def TargetARM : TargetArch<["arm", "thumb", "armeb", "thumbeb"]>; def TargetARM : TargetArch<["arm", "thumb", "armeb", "thumbeb"]>;
def TargetAVR : TargetArch<["avr"]>; def TargetAVR : TargetArch<["avr"]>;
def TargetMips : TargetArch<["mips", "mipsel"]>; def TargetMips : TargetArch<["mips", "mipsel"]>;
def TargetMSP430 : TargetArch<["msp430"]>; def TargetMSP430 : TargetArch<["msp430"]>;
def TargetX86 : TargetArch<["x86"]>; def TargetX86 : TargetArch<["x86"]>;
def TargetAnyX86 : TargetArch<["x86", "x86_64"]>; def TargetAnyX86 : TargetArch<["x86", "x86_64"]>;
def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb"]> { def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
let OSes = ["Win32"]; let OSes = ["Win32"];
} }
def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb"]> { def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
let CXXABIs = ["Microsoft"]; let CXXABIs = ["Microsoft"];
} }
// Attribute subject match rules that are used for #pragma clang attribute. // Attribute subject match rules that are used for #pragma clang attribute.
// //
// A instance of AttrSubjectMatcherRule represents an individual match rule. // A instance of AttrSubjectMatcherRule represents an individual match rule.
// An individual match rule can correspond to a number of different attribute // An individual match rule can correspond to a number of different attribute
// subjects, e.g. "record" matching rule corresponds to the Record and // subjects, e.g. "record" matching rule corresponds to the Record and
▲ Show 20 Lines • Show All 2,495 Lines • Show Last 20 Lines

test/Sema/dllimport.c

// RUN: %clang_cc1 -triple i686-win32 -fsyntax-only -fms-extensions -verify -std=c99 -DMS %s // RUN: %clang_cc1 -triple i686-win32 -fsyntax-only -fms-extensions -verify -std=c99 -DMS %s
// RUN: %clang_cc1 -triple x86_64-win32 -fsyntax-only -fms-extensions -verify -std=c11 -DMS %s // RUN: %clang_cc1 -triple x86_64-win32 -fsyntax-only -fms-extensions -verify -std=c11 -DMS %s
// RUN: %clang_cc1 -triple i686-mingw32 -fsyntax-only -fms-extensions -verify -std=c11 -DGNU %s // RUN: %clang_cc1 -triple i686-mingw32 -fsyntax-only -fms-extensions -verify -std=c11 -DGNU %s
// RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions -verify -std=c99 -DGNU %s // RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions -verify -std=c99 -DGNU %s
// RUN: %clang_cc1 -triple aarch64-win32 -fsyntax-only -fms-extensions -verify -std=c99 -DMS %s
// Invalid usage. // Invalid usage.
__declspec(dllimport) typedef int typedef1; __declspec(dllimport) typedef int typedef1;
// expected-warning@-1{{'dllimport' attribute only applies to variables and functions}} // expected-warning@-1{{'dllimport' attribute only applies to variables and functions}}
typedef __declspec(dllimport) int typedef2; typedef __declspec(dllimport) int typedef2;
// expected-warning@-1{{'dllimport' attribute only applies to variables and functions}} // expected-warning@-1{{'dllimport' attribute only applies to variables and functions}}
typedef int __declspec(dllimport) typedef3; typedef int __declspec(dllimport) typedef3;
// expected-warning@-1{{'dllimport' attribute only applies to variables and functions}} // expected-warning@-1{{'dllimport' attribute only applies to variables and functions}}
▲ Show 20 Lines • Show All 211 Lines • Show Last 20 Lines