This is an archive of the discontinued LLVM Phabricator instance.

Move manifest utils into separate lib, to reduce libxml2 deps.
ClosedPublic

Authored by ecbeckmann on Jul 24 2017, 3:55 PM.

Details

Summary

Previously were in support. Since many many things depend on support,
were all forced to also depend on libxml2, which we only want in a few cases.
This puts all the libxml2 deps in a separate lib to be used only in a few
places.

Event Timeline

ecbeckmann created this revision.Jul 24 2017, 3:55 PM
rnk edited edge metadata.Jul 25 2017, 2:55 PM

Can you remind me if we had any expected clients for manifest merging? Does LLD need to call this logic? If lld doesn't need to call this logic, I'd suggest we move this to tools/llvm-mt.

In D35819#820736, @rnk wrote:

Can you remind me if we had any expected clients for manifest merging? Does LLD need to call this logic? If lld doesn't need to call this logic, I'd suggest we move this to tools/llvm-mt.

LLD will need to call this logic. This will replace the external shell-out to "mt.exe" in DriverUtils, by merging manifests directly in the memory of the same process.

rnk accepted this revision.Jul 25 2017, 4:05 PM

lgtm

This revision is now accepted and ready to land.Jul 25 2017, 4:05 PM
This revision was automatically updated to reflect the committed changes.