This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Allow libignore to handle modules with multiple executable sections
AbandonedPublic

Authored by fjricci on Jul 24 2017, 7:18 AM.

Details

Summary

Darwin procmaps added support for section-level memory mappings.
This patch ensures that libignore doesn't Die() when encountering a suppression
file match in a module with multiple executable sections.

Event Timeline

fjricci created this revision.Jul 24 2017, 7:18 AM
alekseyshl accepted this revision.Jul 24 2017, 7:25 AM
This revision is now accepted and ready to land.Jul 24 2017, 7:25 AM
fjricci planned changes to this revision.Jul 24 2017, 9:08 AM

I think the need for this may actually reveal a deeper issue. Only the address range for the first executable section will be added to the suppression. The two ways around that would be to 1) allow the suppression to take multiple ranges or 2) don't use sections in procmaps for executable segments (lsan doesn't care about executable segments anyway)

fjricci abandoned this revision.Jul 24 2017, 10:27 AM

Ok, I decided that option 2 seemed like the better call, and took care of it in D35799