This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Add support for delay loading DLLs on ARM
ClosedPublic

Authored by mstorsjo on Jul 22 2017, 2:21 PM.

Details

Summary

Is it ok to make the static functions in Chunks.cpp non-static like this, or should they be namespaced/moved any further if they are to be used from other files?

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 22 2017, 2:21 PM
mstorsjo updated this revision to Diff 107813.Jul 23 2017, 3:02 AM

Updated to set the thumb bit via | 1 instead of + 1, moved the setting of the bit into the 32 bit if/else branch, since it won't be used on 64 bit - not as such at least.

ruiu accepted this revision.Jul 25 2017, 12:15 PM

LGTM

This revision is now accepted and ready to land.Jul 25 2017, 12:15 PM
This revision was automatically updated to reflect the committed changes.