This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Make areMemAccessesTriviallyDisjoint more aware of segment flat
ClosedPublic

Authored by arsenm on Jul 20 2017, 7:57 PM.

Details

Reviewers
kzhuravl
rampitec
Summary

Checking the encoding is insufficient since now there can
be global or scratch instructions.

Diff Detail

Event Timeline

arsenm created this revision.Jul 20 2017, 7:57 PM
arsenm updated this revision to Diff 107629.Jul 20 2017, 8:46 PM

Do it correctly

rampitec added inline comments.Jul 21 2017, 10:41 AM
lib/Target/AMDGPU/SIInstrInfo.h
425

The name is confusing. Flat segments covers all other segments, so it is always a flat segment.

arsenm added inline comments.Jul 21 2017, 10:46 AM
lib/Target/AMDGPU/SIInstrInfo.h
425

The FLAT refers only the the encoding. It's a segment specific flat

rampitec added inline comments.Jul 21 2017, 10:55 AM
lib/Target/AMDGPU/SIInstrInfo.h
425

isSegmentSpecificFLAT() maybe?

arsenm updated this revision to Diff 107697.Jul 21 2017, 12:03 PM

Rename hook

This revision is now accepted and ready to land.Jul 21 2017, 12:09 PM
arsenm closed this revision.Jul 28 2017, 6:27 PM

r309472