This is an archive of the discontinued LLVM Phabricator instance.

Remove Bitrig: LLVM Changes
ClosedPublic

Authored by erichkeane on Jul 20 2017, 4:35 PM.

Details

Summary

Bitrig code has been merged back to OpenBSD, thus the OS has been abandoned.

Diff Detail

Repository
rL LLVM

Event Timeline

erichkeane created this revision.Jul 20 2017, 4:35 PM
krytarowski added inline comments.Jul 20 2017, 4:52 PM
cmake/config.guess
209 ↗(On Diff #107602)

Is this 3rd party file? If so, it should be leaved as it is.

echristo accepted this revision.Jul 20 2017, 4:52 PM

LGTM.

This revision is now accepted and ready to land.Jul 20 2017, 4:52 PM
echristo added inline comments.Jul 20 2017, 4:59 PM
cmake/config.guess
209 ↗(On Diff #107602)

I added this as part of the Bitrig support and while it's still there in the upstream sources we don't sync other than as necessary with the upstream sources. It can probably just be deleted.

krytarowski accepted this revision.Jul 20 2017, 5:09 PM
krytarowski added inline comments.
cmake/config.guess
209 ↗(On Diff #107602)

Nobody cares any more about this entry, I'm fine either way.

This revision was automatically updated to reflect the committed changes.
hans added a subscriber: hans.Jul 26 2017, 10:15 AM

Want to add a mention of this in docs/ReleaseNotes.rst?

In D35707#821776, @hans wrote:

Want to add a mention of this in docs/ReleaseNotes.rst?

I can definitely do that. Can I target the trunk, or is there a 5.0 release branch already? Additionally, is there any good spot for it? I looked and don't really see a good section for it.

hans added a comment.Jul 26 2017, 10:26 AM
In D35707#821776, @hans wrote:

Want to add a mention of this in docs/ReleaseNotes.rst?

I can definitely do that. Can I target the trunk, or is there a 5.0 release branch already? Additionally, is there any good spot for it? I looked and don't really see a good section for it.

There is a 5.0 release branch, but that was created before your changes, so I believe this should go in the trunk release notes.

I'd just put the note in the "Non-comprehensive list of changes in this release" section.