This is an archive of the discontinued LLVM Phabricator instance.

Differential D35593

ThinLTOBitcodeWriter: Do not rewrite intrinsic functions when splitting modules.
ClosedPublic

Authored by pcc on Jul 18 2017, 5:30 PM.

Details

Reviewers
tejohnson
Commits
rG93fdaca5ac32: ThinLTOBitcodeWriter: Do not rewrite intrinsic functions when splitting modules.
rL308500: ThinLTOBitcodeWriter: Do not rewrite intrinsic functions when splitting modules.
Summary

Changing the type of an intrinsic may invalidate the IR.

Diff Detail

Event Timeline

pcc created this revision.Jul 18 2017, 5:30 PM
Herald added subscribers: hiraditya, eraman, inglorion, mehdi_amini. · View Herald TranscriptJul 18 2017, 5:30 PM
Harbormaster completed remote builds in B8375: Diff 107213.Jul 18 2017, 5:32 PM
tejohnson accepted this revision.Jul 19 2017, 6:55 AM

LGTM

llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
145

Suggest adding a comment.

This revision is now accepted and ready to land.Jul 19 2017, 6:55 AM
Closed by commit rL308500: ThinLTOBitcodeWriter: Do not rewrite intrinsic functions when splitting modules. (authored by pcc). · Explain WhyJul 19 2017, 10:54 AM
This revision was automatically updated to reflect the committed changes.
pcc marked an inline comment as done.

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
3 lines
test/
Transforms/
ThinLTOBitcodeWriter/
4 lines

Diff 107213

llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesvoid simplifyExternals(Module &M) {
for (auto I = M.begin(), E = M.end(); I != E;) { for (auto I = M.begin(), E = M.end(); I != E;) {
Function &F = *I++; Function &F = *I++;
if (F.isDeclaration() && F.use_empty()) { if (F.isDeclaration() && F.use_empty()) {
F.eraseFromParent(); F.eraseFromParent();
continue; continue;
} }
if (!F.isDeclaration() || F.getFunctionType() == EmptyFT) if (!F.isDeclaration() || F.getFunctionType() == EmptyFT ||
F.getName().startswith("llvm."))
tejohnsonUnsubmitted
Done
ReplyInline Actions

Suggest adding a comment.

tejohnson: Suggest adding a comment.
continue; continue;
Function *NewF = Function *NewF =
Function::Create(EmptyFT, GlobalValue::ExternalLinkage, "", &M); Function::Create(EmptyFT, GlobalValue::ExternalLinkage, "", &M);
NewF->setVisibility(F.getVisibility()); NewF->setVisibility(F.getVisibility());
NewF->takeName(&F); NewF->takeName(&F);
F.replaceAllUsesWith(ConstantExpr::getBitCast(NewF, F.getType())); F.replaceAllUsesWith(ConstantExpr::getBitCast(NewF, F.getType()));
F.eraseFromParent(); F.eraseFromParent();
▲ Show 20 Lines • Show All 339 Lines • Show Last 20 Lines

llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc.ll

Show All 19 Lines
; M1: define available_externally i64 @ok1 ; M1: define available_externally i64 @ok1
define i64 @ok1(i8* %this) { define i64 @ok1(i8* %this) {
ret i64 42 ret i64 42
} }
; M0: define i64 @ok2 ; M0: define i64 @ok2
; M1: define available_externally i64 @ok2 ; M1: define available_externally i64 @ok2
define i64 @ok2(i8* %this, i64 %arg) { define i64 @ok2(i8* %this, i64 %arg) {
%1 = tail call { i64, i1 } @llvm.sadd.with.overflow.i64(i64 %arg, i64 %arg)
ret i64 %arg ret i64 %arg
} }
; M1: declare { i64, i1 } @llvm.sadd.with.overflow.i64(i64, i64)
declare { i64, i1 } @llvm.sadd.with.overflow.i64(i64, i64)
; M0: define void @wrongtype1 ; M0: define void @wrongtype1
; M1: declare void @wrongtype1() ; M1: declare void @wrongtype1()
define void @wrongtype1(i8*) { define void @wrongtype1(i8*) {
ret void ret void
} }
; M0: define i128 @wrongtype2 ; M0: define i128 @wrongtype2
; M1: declare void @wrongtype2() ; M1: declare void @wrongtype2()
Show All 37 Lines