This is an archive of the discontinued LLVM Phabricator instance.

Differential D35322

[WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported
ClosedPublic

Authored by aheejin on Jul 12 2017, 12:53 PM.

Details

Reviewers
sunfish
dschuff
sbc100
Commits
rG1bf3bf234c05: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported
rL307841: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported
Summary

Element atomic intrinsicAtomic instructions are not yet supported in WebAssembly, so we mark them as
unsupported for the moment.

Diff Detail

Event Timeline

aheejin created this revision.Jul 12 2017, 12:53 PM
Herald added subscribers: jgravelle-google, sbc100, jfb. · View Herald TranscriptJul 12 2017, 12:53 PM
sbc100 accepted this revision.Jul 12 2017, 1:08 PM

Thanks!

This revision is now accepted and ready to land.Jul 12 2017, 1:08 PM
aheejin updated this revision to Diff 106297.Jul 12 2017, 1:42 PM

Made atomic memcpy/memmove intrinsics as unsupported for now. And also made the comments consistent with the up-to-date intrinsic names.

Harbormaster completed remote builds in B8174: Diff 106297.Jul 12 2017, 1:42 PM
aheejin retitled this revision from [WebAssembly] Add element atomic memmove intrinsics to runtime library calls to [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.Jul 12 2017, 1:45 PM
aheejin edited the summary of this revision. (Show Details)
sbc100 accepted this revision.Jul 12 2017, 1:45 PM
aheejin added a comment.Jul 12 2017, 1:45 PM

@dschuff PTAL

dschuff accepted this revision.Jul 12 2017, 1:48 PM

LGTM.
Looking forward to reversing all of this soon :)

aheejin closed this revision.Jul 12 2017, 1:50 PM

Revision Contents

PathSize
lib/
Target/
WebAssembly/
30 lines

Diff 106288

lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp

Show First 20 Lines • Show All 388 Lines • ▼ Show 20 Lines
/* O_PPCF128 */ unsupported, /* O_PPCF128 */ unsupported,
// MEMORY // MEMORY
/* MEMCPY */ iPTR_func_iPTR_iPTR_iPTR, /* MEMCPY */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMSET */ iPTR_func_iPTR_i32_iPTR, /* MEMSET */ iPTR_func_iPTR_i32_iPTR,
/* MEMMOVE */ iPTR_func_iPTR_iPTR_iPTR, /* MEMMOVE */ iPTR_func_iPTR_iPTR_iPTR,
// ELEMENT-WISE ATOMIC MEMORY // ELEMENT-WISE ATOMIC MEMORY
/* MEMCPY_ELEMENT_ATOMIC_1 */ iPTR_func_iPTR_iPTR_iPTR, /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_1 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMCPY_ELEMENT_ATOMIC_2 */ iPTR_func_iPTR_iPTR_iPTR, /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_2 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMCPY_ELEMENT_ATOMIC_4 */ iPTR_func_iPTR_iPTR_iPTR, /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_4 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMCPY_ELEMENT_ATOMIC_8 */ iPTR_func_iPTR_iPTR_iPTR, /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_8 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMCPY_ELEMENT_ATOMIC_16 */ iPTR_func_iPTR_iPTR_iPTR, /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_16 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_1 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_2 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_4 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_8 */ iPTR_func_iPTR_iPTR_iPTR,
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_16 */ iPTR_func_iPTR_iPTR_iPTR,
// EXCEPTION HANDLING // EXCEPTION HANDLING
/* UNWIND_RESUME */ unsupported, /* UNWIND_RESUME */ unsupported,
// Note: there's two sets of atomics libcalls; see // Note: there's two sets of atomics libcalls; see
// <http://llvm.org/docs/Atomics.html> for more info on the // <http://llvm.org/docs/Atomics.html> for more info on the
// difference between them. // difference between them.
▲ Show 20 Lines • Show All 424 Lines • ▼ Show 20 Lines
/* UO_PPCF128 */ nullptr, /* UO_PPCF128 */ nullptr,
/* O_F32 */ "__unordsf2", /* O_F32 */ "__unordsf2",
/* O_F64 */ "__unorddf2", /* O_F64 */ "__unorddf2",
/* O_F128 */ "__unordtf2", /* O_F128 */ "__unordtf2",
/* O_PPCF128 */ nullptr, /* O_PPCF128 */ nullptr,
/* MEMCPY */ "memcpy", /* MEMCPY */ "memcpy",
/* MEMMOVE */ "memset", /* MEMMOVE */ "memset",
/* MEMSET */ "memmove", /* MEMSET */ "memmove",
/* MEMCPY_ELEMENT_ATOMIC_1 */ "MEMCPY_ELEMENT_ATOMIC_1", /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_1 */ "MEMCPY_ELEMENT_UNORDERD_ATOMIC_1",
/* MEMCPY_ELEMENT_ATOMIC_2 */ "MEMCPY_ELEMENT_ATOMIC_2", /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_2 */ "MEMCPY_ELEMENT_UNORDERD_ATOMIC_2",
/* MEMCPY_ELEMENT_ATOMIC_4 */ "MEMCPY_ELEMENT_ATOMIC_4", /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_4 */ "MEMCPY_ELEMENT_UNORDERD_ATOMIC_4",
/* MEMCPY_ELEMENT_ATOMIC_8 */ "MEMCPY_ELEMENT_ATOMIC_8", /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_8 */ "MEMCPY_ELEMENT_UNORDERD_ATOMIC_8",
/* MEMCPY_ELEMENT_ATOMIC_16 */ "MEMCPY_ELEMENT_ATOMIC_16", /* MEMCPY_ELEMENT_UNORDERED_ATOMIC_16 */ "MEMCPY_ELEMENT_UNORDERD_ATOMIC_16",
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_1 */ "MEMMOVE_ELEMENT_UNORDERD_ATOMIC_1",
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_2 */ "MEMMOVE_ELEMENT_UNORDERD_ATOMIC_2",
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_4 */ "MEMMOVE_ELEMENT_UNORDERD_ATOMIC_4",
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_8 */ "MEMMOVE_ELEMENT_UNORDERD_ATOMIC_8",
/* MEMMOVE_ELEMENT_UNORDERED_ATOMIC_16 */ "MEMMOVE_ELEMENT_UNORDERD_ATOMIC_16",
/* UNWIND_RESUME */ "_Unwind_Resume", /* UNWIND_RESUME */ "_Unwind_Resume",
/* SYNC_VAL_COMPARE_AND_SWAP_1 */ "__sync_val_compare_and_swap_1", /* SYNC_VAL_COMPARE_AND_SWAP_1 */ "__sync_val_compare_and_swap_1",
/* SYNC_VAL_COMPARE_AND_SWAP_2 */ "__sync_val_compare_and_swap_2", /* SYNC_VAL_COMPARE_AND_SWAP_2 */ "__sync_val_compare_and_swap_2",
/* SYNC_VAL_COMPARE_AND_SWAP_4 */ "__sync_val_compare_and_swap_4", /* SYNC_VAL_COMPARE_AND_SWAP_4 */ "__sync_val_compare_and_swap_4",
/* SYNC_VAL_COMPARE_AND_SWAP_8 */ "__sync_val_compare_and_swap_8", /* SYNC_VAL_COMPARE_AND_SWAP_8 */ "__sync_val_compare_and_swap_8",
/* SYNC_VAL_COMPARE_AND_SWAP_16 */ "__sync_val_compare_and_swap_16", /* SYNC_VAL_COMPARE_AND_SWAP_16 */ "__sync_val_compare_and_swap_16",
/* SYNC_LOCK_TEST_AND_SET_1 */ "__sync_lock_test_and_set_1", /* SYNC_LOCK_TEST_AND_SET_1 */ "__sync_lock_test_and_set_1",
/* SYNC_LOCK_TEST_AND_SET_2 */ "__sync_lock_test_and_set_2", /* SYNC_LOCK_TEST_AND_SET_2 */ "__sync_lock_test_and_set_2",
▲ Show 20 Lines • Show All 448 Lines • Show Last 20 Lines