This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] add regression test to performance-unnecessary-value-param
ClosedPublic

Authored by chh on Jul 10 2017, 4:20 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

chh created this revision.Jul 10 2017, 4:20 PM
chh added subscribers: srhines, cfe-commits.

These tests should be added after https://bugs.llvm.org/show_bug.cgi?id=33734 is fixed.

alexfh requested changes to this revision.Jul 11 2017, 6:15 AM
alexfh added inline comments.
test/clang-tidy/performance-unnecessary-value-param.cpp
1 ↗(On Diff #105933)

I'd leave this test alone and add a separate one to test the fix in the header.

2 ↗(On Diff #105933)

No need to copy this file, the test doesn't change it.

This revision now requires changes to proceed.Jul 11 2017, 6:15 AM
chh updated this revision to Diff 106064.Jul 11 2017, 10:36 AM
chh edited edge metadata.
chh marked 2 inline comments as done.
alexfh accepted this revision.Jul 12 2017, 6:22 AM

LG. Thanks!

This revision is now accepted and ready to land.Jul 12 2017, 6:22 AM
This revision was automatically updated to reflect the committed changes.