- User Since
- Sep 14 2015, 7:53 AM (300 w, 6 d)
Fri, Jun 18
Renamed initializer matcher.
Tue, Jun 15
Remove now unnecessary FunctionDecl.
Directly examine initializer.
Fri, Jun 11
Use more efficient method to check for local variable declaration.
Wed, Jun 9
Addressed first round of comments.
Thank you for the review, Yitzhak!
Tue, May 25
Mon, May 24
May 14 2021
May 12 2021
Could someone take a look at this patch? Thank you!
May 10 2021
Fix test case.
Apr 6 2021
Apr 5 2021
Could someone take a look at this change?
Thanks for the comments, PTAL!
Create a NameMatcher class that handles matching against the best name variant
(unqualified, qualified, fully qualified) of the NamedDecl.
Mar 19 2021
Applied changes suggested by ymandel, thanks!
Mar 17 2021
Mar 16 2021
Mar 15 2021
could someone please take a look at this? Thanks!
Mar 2 2021
Thank you for the review!
Feb 28 2021
Feb 26 2021
Add tests for PerformanceUnnecssaryCopyInitialization check which actually uses
Dec 10 2020
Shortened isa<> expression.
Added positive variants of new tests.
Dec 8 2020
Thanks for the review, Aaron! I appreciate it. Please let me know if you have any questions about the test cases.
Address review comments.
Dec 7 2020
Could someone take a first pass at this change? It would be great progress on this as this is the last currently known case that generates false positives.
Dec 3 2020
Fixed clang tidy warnings.
Nov 20 2020
Fix formatting and comments.
Nov 16 2020
Nov 12 2020
Updated change description.
Remove unnecessary test code that is not needed.
Fixed definition of fake std::function which now makes the bug fixed by this change reproducible.
Nov 11 2020
Oct 28 2020
Comment out replaced parameter.
Add instantiated template method.
Oct 27 2020
Oct 23 2020
I should note that I was only able to reproduce the false positive with the actual implementation std::function and not our fake version here.
Revert -std=c++17 change.
Remove code comment.
Oct 21 2020
Added a fake std function that still triggers the check.
Add fake std function to ensure it is still matched.
Fix compile errors.
Oct 20 2020
Thank you all for the input!
Use hasName matcher on the declaration of the canonical type.
Oct 16 2020
Add more complete fake version of std::function.
Oct 15 2020
Oct 13 2020
Sep 14 2020
Thank you for the review, Aaron!
Sep 10 2020
The motivating false positive was the free functions std::min. To not limit the usefulness of the check I'll only disable arguments for free functions for now. Updated change coming.