Page MenuHomePhabricator

flx (Felix Berger)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2015, 7:53 AM (376 w, 18 h)

Recent Activity

May 20 2022

flx added a comment to D116593: Fix `performance-unnecessary-value-param` for template specialization.

I don't have access to Windows, perhaps rebase and try again? It looks like the template specialization related tests are failing there though.

May 20 2022, 5:55 PM · Restricted Project, Restricted Project

Mar 8 2022

flx accepted D116593: Fix `performance-unnecessary-value-param` for template specialization.
Mar 8 2022, 7:16 AM · Restricted Project, Restricted Project

Mar 1 2022

flx added a comment to D116593: Fix `performance-unnecessary-value-param` for template specialization.

I'm still seeing build failures. Could you resolve them?

Mar 1 2022, 9:54 AM · Restricted Project, Restricted Project

Jan 14 2022

flx added inline comments to D116593: Fix `performance-unnecessary-value-param` for template specialization.
Jan 14 2022, 7:10 AM · Restricted Project, Restricted Project

Jan 4 2022

flx accepted D116535: [clang-tidy] Fix false positive in modernize-pass-by-value.
Jan 4 2022, 7:01 AM · Restricted Project
flx added a comment to D116593: Fix `performance-unnecessary-value-param` for template specialization.

Thanks for improving this check!

Jan 4 2022, 6:44 AM · Restricted Project, Restricted Project

Dec 15 2021

flx added a comment to D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType..

Hi, this patch is causing a build failure for clang-ppc64le-rhel, can this be reverted?

Dec 15 2021, 11:19 AM · Restricted Project
flx committed rG54ed30fdd63b: [ASTMatchers] Make ParamIndex unsigned. (authored by flx).
[ASTMatchers] Make ParamIndex unsigned.
Dec 15 2021, 10:50 AM
flx closed D115809: [ASTMatchers] Make ParamIndex unsigned..
Dec 15 2021, 10:49 AM · Restricted Project
flx requested review of D115809: [ASTMatchers] Make ParamIndex unsigned..
Dec 15 2021, 10:37 AM · Restricted Project
flx committed rGa1b1c23a3b5f: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType. (authored by flx).
[clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.
Dec 15 2021, 9:37 AM
flx closed D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType..
Dec 15 2021, 9:36 AM · Restricted Project

Dec 7 2021

flx added reviewers for D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.: sammccall, njames93.
Dec 7 2021, 7:22 AM · Restricted Project

Nov 24 2021

flx requested review of D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType..
Nov 24 2021, 12:09 PM · Restricted Project
flx added a comment to D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers..

This looks great, but goes past my knowledge of the AST API :) While the existing and new test coverage provides good confidence, one other reviewer taking look would be good.

Nov 24 2021, 8:17 AM · Restricted Project

Nov 23 2021

flx accepted D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative..
Nov 23 2021, 7:29 AM · Restricted Project
flx accepted D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative..
Nov 23 2021, 6:40 AM · Restricted Project

Nov 20 2021

flx committed rGfefe20b99313: [clang-tidy] performance-unnecessary-copy-initialization: Correctly match the… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Correctly match the…
Nov 20 2021, 12:15 PM
flx closed D114212: [clang-tidy] performance-unnecessary-copy-initialization: Correctly match the type name of the thisPointertype..
Nov 20 2021, 12:15 PM · Restricted Project

Nov 19 2021

flx added a comment to D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative..

Thank you for catching and fixing this!

Nov 19 2021, 5:13 PM · Restricted Project

Nov 18 2021

flx requested review of D114212: [clang-tidy] performance-unnecessary-copy-initialization: Correctly match the type name of the thisPointertype..
Nov 18 2021, 5:37 PM · Restricted Project

Oct 28 2021

flx accepted D112722: [clang-tidy]performance-unnecessary-copy-initialization: fix false negative.

Thanks for the fix!

Oct 28 2021, 8:18 AM · Restricted Project

Jul 22 2021

flx committed rGcb4c12b6117a: [clang-tidy] performance-unnecessary-copy-initialization: Create option to… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Create option to…
Jul 22 2021, 1:21 PM
flx closed D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check..
Jul 22 2021, 1:21 PM · Restricted Project
flx committed rG00edae9203c9: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Disable check when…
Jul 22 2021, 12:18 PM
flx closed D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types..
Jul 22 2021, 12:18 PM · Restricted Project
flx added inline comments to D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types..
Jul 22 2021, 10:10 AM · Restricted Project
flx updated the diff for D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types..

Addressed review feedback.

Jul 22 2021, 10:10 AM · Restricted Project
flx added a comment to D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check..

I also added a file testing the new option.

Jul 22 2021, 10:06 AM · Restricted Project
flx updated the diff for D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check..

Add test file for the new option.

Jul 22 2021, 10:05 AM · Restricted Project

Jul 16 2021

flx requested review of D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check..
Jul 16 2021, 11:46 AM · Restricted Project

Jul 14 2021

flx requested review of D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types..
Jul 14 2021, 1:15 PM · Restricted Project

Jul 12 2021

flx committed rG0ec812023b43: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Do not remove…
Jul 12 2021, 1:23 PM
flx closed D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines..
Jul 12 2021, 1:23 PM · Restricted Project
flx updated the diff for D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines..

Invert end of string logic.

Jul 12 2021, 11:40 AM · Restricted Project
flx added a comment to D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines..

Thanks for the review!

Jul 12 2021, 11:01 AM · Restricted Project
flx updated the diff for D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines..

Make offset operations safer.

Jul 12 2021, 10:59 AM · Restricted Project
flx committed rG187e050b33bb: [clang-tidy] performance-unnecessary-copy-initialization: Disable structured… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Disable structured…
Jul 12 2021, 6:56 AM
flx closed D105727: [clang-tidy] performance-unnecessary-copy-initialization: Disable structured bindings..
Jul 12 2021, 6:56 AM · Restricted Project

Jul 9 2021

flx requested review of D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines..
Jul 9 2021, 2:00 PM · Restricted Project
flx requested review of D105727: [clang-tidy] performance-unnecessary-copy-initialization: Disable structured bindings..
Jul 9 2021, 1:00 PM · Restricted Project

Jun 18 2021

flx committed rGbdd5da9dec61: [clang-tidy] performance-unnecessary-copy-initialization: Directly examine the… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Directly examine the…
Jun 18 2021, 12:27 PM
flx closed D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..
Jun 18 2021, 12:27 PM · Restricted Project
flx updated the diff for D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..

Renamed initializer matcher.

Jun 18 2021, 11:26 AM · Restricted Project

Jun 15 2021

flx added inline comments to D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..
Jun 15 2021, 1:40 PM · Restricted Project
flx updated the diff for D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..

Remove now unnecessary FunctionDecl.

Jun 15 2021, 1:37 PM · Restricted Project
flx updated the diff for D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..

Directly examine initializer.

Jun 15 2021, 1:34 PM · Restricted Project

Jun 11 2021

flx added a comment to D103087: [clang-tidy] performances-unnecessary-* checks: Extend isOnlyUsedAsConst to expressions and catch const methods returning non-const references/pointers..

I have some concerns about the cost of this checks as it used matching over entire contexts quite extensively. At this point, the facilities involved seem quite close to doing dataflow analysis and I wonder if you might be better off with a very different implementation. Regardless, have you done any perfomance testing to see the impact on real code?

Jun 11 2021, 11:21 AM · Restricted Project
flx added inline comments to D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..
Jun 11 2021, 6:00 AM · Restricted Project
flx updated the diff for D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..

Use more efficient method to check for local variable declaration.

Jun 11 2021, 5:55 AM · Restricted Project

Jun 9 2021

flx added inline comments to D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..
Jun 9 2021, 2:13 PM · Restricted Project
flx updated the diff for D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..

Addressed first round of comments.

Jun 9 2021, 2:13 PM · Restricted Project
flx committed rGefa4dbc32ca9: [clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical…
Jun 9 2021, 1:37 PM
flx closed D103018: [clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical type when checking for aliases..
Jun 9 2021, 1:37 PM · Restricted Project
flx committed rG5dbe3bf4b8db: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Remove the complete…
Jun 9 2021, 12:54 PM
flx closed D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused..
Jun 9 2021, 12:54 PM · Restricted Project
flx added a comment to D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused..

Thank you for the review, Yitzhak!

Jun 9 2021, 12:51 PM · Restricted Project

May 25 2021

flx requested review of D103087: [clang-tidy] performances-unnecessary-* checks: Extend isOnlyUsedAsConst to expressions and catch const methods returning non-const references/pointers..
May 25 2021, 7:34 AM · Restricted Project

May 24 2021

flx requested review of D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations..
May 24 2021, 6:50 AM · Restricted Project
flx requested review of D103018: [clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical type when checking for aliases..
May 24 2021, 6:27 AM · Restricted Project

May 14 2021

flx added a comment to D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused..

Hi Felix,
Can you clarify your concern over the warning? Is it the case that the warning is not present before the fix and is only triggered after the fix? I'm concerned that removing the call may have unintended side effects and I would think it might better to leave the check for usage separate. However, if the fix is causing the warning then I can understand better why you want to make this change. That said, have considered replacing the var binding with (void), rather than deleting the statement?

May 14 2021, 10:28 AM · Restricted Project

May 12 2021

flx added a comment to D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner..

Could someone take a look at this patch? Thank you!

May 12 2021, 7:00 AM · Restricted Project, Restricted Project

May 10 2021

flx updated the diff for D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused..

Fix test case.

May 10 2021, 12:31 PM · Restricted Project
flx requested review of D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused..
May 10 2021, 8:46 AM · Restricted Project

Apr 6 2021

flx committed rGddebed8e9742: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type… (authored by flx).
[clang-tidy] performance-* checks: Match AllowedTypes against qualified type…
Apr 6 2021, 12:42 PM
flx closed D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..
Apr 6 2021, 12:42 PM · Restricted Project

Apr 5 2021

flx added a comment to D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner..

Could someone take a look at this change?

Apr 5 2021, 10:56 AM · Restricted Project, Restricted Project
flx added a comment to D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..

Thanks for the comments, PTAL!

Apr 5 2021, 8:54 AM · Restricted Project
flx updated the diff for D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..

Create a NameMatcher class that handles matching against the best name variant
(unqualified, qualified, fully qualified) of the NamedDecl.

Apr 5 2021, 8:53 AM · Restricted Project

Mar 19 2021

flx added inline comments to D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..
Mar 19 2021, 11:12 AM · Restricted Project
flx updated the diff for D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..

Applied changes suggested by ymandel, thanks!

Mar 19 2021, 11:01 AM · Restricted Project

Mar 17 2021

flx added inline comments to D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..
Mar 17 2021, 8:38 AM · Restricted Project
flx added inline comments to D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..
Mar 17 2021, 7:05 AM · Restricted Project

Mar 16 2021

flx updated subscribers of D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..
Mar 16 2021, 1:14 PM · Restricted Project
flx requested review of D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..
Mar 16 2021, 1:13 PM · Restricted Project

Mar 15 2021

flx added a comment to D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner..

could someone please take a look at this? Thanks!

Mar 15 2021, 1:21 PM · Restricted Project, Restricted Project

Mar 2 2021

flx committed rGa189b3b9e8bb: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type… (authored by flx).
[clang-tidy] performance-for-range-copy: Don't trigger on implicit type…
Mar 2 2021, 5:04 PM
flx closed D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions..
Mar 2 2021, 5:04 PM · Restricted Project, Restricted Project
flx added a comment to D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions..

Thank you for the review!

Mar 2 2021, 5:01 PM · Restricted Project, Restricted Project

Feb 28 2021

flx added a comment to D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions..

It is best not to change existing tests, but add new ones.

Feb 28 2021, 8:10 AM · Restricted Project, Restricted Project

Feb 26 2021

flx updated the diff for D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner..

Add tests for PerformanceUnnecssaryCopyInitialization check which actually uses
decl_ref_expr::isOnlyUsedAsConst().

Feb 26 2021, 2:03 PM · Restricted Project, Restricted Project
flx updated the diff for D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions..

Remove include.

Feb 26 2021, 1:38 PM · Restricted Project, Restricted Project
flx updated the diff for D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions..

Remove include.

Feb 26 2021, 1:37 PM · Restricted Project, Restricted Project
flx requested review of D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions..
Feb 26 2021, 1:36 PM · Restricted Project, Restricted Project
flx requested review of D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner..
Feb 26 2021, 11:13 AM · Restricted Project, Restricted Project

Dec 10 2020

flx committed rG671ad580610a: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Prevent false…
Dec 10 2020, 1:59 PM
flx closed D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..
Dec 10 2020, 1:58 PM · Restricted Project, Restricted Project
flx updated the diff for D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..

Shortened isa<> expression.

Dec 10 2020, 12:56 PM · Restricted Project, Restricted Project
flx added inline comments to D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..
Dec 10 2020, 7:40 AM · Restricted Project, Restricted Project
flx updated the diff for D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..

Added positive variants of new tests.

Dec 10 2020, 7:37 AM · Restricted Project, Restricted Project

Dec 8 2020

flx added a comment to D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..

Thanks for the review, Aaron! I appreciate it. Please let me know if you have any questions about the test cases.

Dec 8 2020, 10:53 AM · Restricted Project, Restricted Project
flx updated the diff for D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..

Address review comments.

Dec 8 2020, 10:50 AM · Restricted Project, Restricted Project

Dec 7 2020

flx added a comment to D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..

Could someone take a first pass at this change? It would be great progress on this as this is the last currently known case that generates false positives.

Dec 7 2020, 6:16 AM · Restricted Project, Restricted Project

Dec 3 2020

flx updated the diff for D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..

Fixed clang tidy warnings.

Dec 3 2020, 2:02 PM · Restricted Project, Restricted Project

Nov 20 2020

flx added a reviewer for D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.: ckennelly.
Nov 20 2020, 7:52 PM · Restricted Project, Restricted Project
flx updated the diff for D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..

Fix formatting and comments.

Nov 20 2020, 1:44 PM · Restricted Project, Restricted Project
flx requested review of D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified..
Nov 20 2020, 1:38 PM · Restricted Project, Restricted Project

Nov 16 2020

flx committed rGace9653c11c6: [clang-tidy] performance-unnecessary-copy-initialization: Check for const… (authored by flx).
[clang-tidy] performance-unnecessary-copy-initialization: Check for const…
Nov 16 2020, 2:09 PM
flx closed D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type..
Nov 16 2020, 2:09 PM · Restricted Project, Restricted Project
flx added a comment to D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type..

LGTM, thank you for the fix!

Nov 16 2020, 12:35 PM · Restricted Project, Restricted Project