This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add more details to llvm-readobj for wasm files
ClosedPublic

Authored by sbc100 on Jul 10 2017, 9:41 AM.

Event Timeline

sbc100 created this revision.Jul 10 2017, 9:41 AM
sbc100 added a subscriber: llvm-commits.
dschuff edited edge metadata.EditedJul 10 2017, 9:45 AM

Code looks good. Maybe also add a test to test/MC/WebAssembly/reloc-data.ll or one of those others too?

sbc100 updated this revision to Diff 105889.Jul 10 2017, 11:21 AM
  • rebase and update test

So trivial.obj.wasm already has the updated linking section or this patch just depends on updating it?

Yes this patch depends on the one that just landed that updated the binary.

This patch itself only changes the information output about the binary, no the binary itself.

dschuff accepted this revision.Jul 10 2017, 1:46 PM

Cool, LGTM

This revision is now accepted and ready to land.Jul 10 2017, 1:46 PM
This revision was automatically updated to reflect the committed changes.