This is an archive of the discontinued LLVM Phabricator instance.

Only check shadow memory for operands that are sized.
ClosedPublic

Authored by morehouse on Jul 7 2017, 4:06 PM.

Event Timeline

morehouse created this revision.Jul 7 2017, 4:06 PM
morehouse updated this revision to Diff 105723.Jul 7 2017, 4:11 PM

Update test comment.

Harbormaster completed remote builds in B8071: Diff 105723.
EricWF added a subscriber: EricWF.Jul 9 2017, 3:21 PM

@morehouse Thanks for fixing this!

eugenis accepted this revision.Jul 10 2017, 11:36 AM
eugenis added inline comments.
llvm/test/Instrumentation/MemorySanitizer/unsized_type.ll
18

remove the comment lines

This revision is now accepted and ready to land.Jul 10 2017, 11:36 AM
  • Removed unused attributes from test.
eugenis added inline comments.Jul 10 2017, 3:50 PM
llvm/test/Instrumentation/MemorySanitizer/unsized_type.ll
18

In fact, the assertion failure is not really the point of this test. Please make it a positive one - check the instrumentation (or lack of it) of @foo.

morehouse updated this revision to Diff 106029.Jul 11 2017, 8:18 AM
  • Convert unsized_type negative test to a positive test.
eugenis accepted this revision.Jul 11 2017, 10:42 AM
This revision was automatically updated to reflect the committed changes.