Only check shadow memory for operands that are sized.

[morehouse]

Summary

Fixes https://bugs.llvm.org/show_bug.cgi?id=33347.

[morehouse]

Update test comment.

[EricWF]

@morehouse Thanks for fixing this!

[eugenis]

llvm/test/Instrumentation/MemorySanitizer/unsized_type.ll

18 ↗

(On Diff #105723)

remove the comment lines

[morehouse]

• Removed unused attributes from test.

[eugenis]

llvm/test/Instrumentation/MemorySanitizer/unsized_type.ll

18 ↗

(On Diff #105723)

In fact, the assertion failure is not really the point of this test. Please make it a positive one - check the instrumentation (or lack of it) of @foo.

[morehouse]

• Convert unsized_type negative test to a positive test.

llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp

void visitCatchReturnInst(CatchReturnInst &CRI) {
     // Nothing to do here.
   }
 
   void visitInstruction(Instruction &I) {
     // Everything else: stop propagating and check for poisoned shadow.
     if (ClDumpStrictInstructions)
       dumpInst(I);
     DEBUG(dbgs() << "DEFAULT: " << I << "\n");
-    for (size_t i = 0, n = I.getNumOperands(); i < n; i++)
-      insertShadowCheck(I.getOperand(i), &I);
+    for (size_t i = 0, n = I.getNumOperands(); i < n; i++) {
+      Value *Operand = I.getOperand(i);
+      if (Operand->getType()->isSized())
+        insertShadowCheck(Operand, &I);
+    }
     setShadow(&I, getCleanShadow(&I));
     setOrigin(&I, getCleanOrigin());
   }
 };
 
 /// \brief AMD64-specific implementation of VarArgHelper.
 struct VarArgAMD64Helper : public VarArgHelper {
   // An unfortunate workaround for asymmetric lowering of va_arg stuff.

llvm/trunk/test/Instrumentation/MemorySanitizer/unsized_type.ll

+; Check that unsized token types used by coroutine intrinsics do not cause
+; assertion failures.
+; RUN: opt < %s -msan -S 2>&1 | FileCheck %s
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+declare token @llvm.coro.id(i32, i8* readnone, i8* nocapture readonly, i8*)
+declare i1 @llvm.coro.alloc(token)
+
+define void @foo() sanitize_memory {
+entry:
+  %id = call token @llvm.coro.id(i32 0, i8* null, i8* null, i8* null)
+  %dyn.alloc.reqd = call i1  @llvm.coro.alloc(token %id)
+  ret void
+}
+
+; CHECK: define void @foo
+; CHECK-NEXT: entry:
+; CHECK-NEXT: %id = call token @llvm.coro.id
+; CHECK-NEXT: call i1 @llvm.coro.alloc(token %id)
+; CHECK-NEXT: ret void