This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Use new GetSVN.cmake SOURCE_DIRS parameter
AcceptedPublic

Authored by modocache on Jul 7 2017, 11:14 AM.

Details

Summary

Depends on LLVM https://reviews.llvm.org/D35132.

Instead of the old FIRST_SOURCE_DIR/FIRST_NAME,
SECOND_SOURCE_DIR/SECOND_NAME parameters, use the new
SOURCE_DIRS/NAMES list parameter. This allows the old parameters to
be deleted.

Test Plan:

  1. Perform a clean build of Clang, verify that clang --version still prints the correct LLVM and Clang revision information.
  2. Apply this patch to use the new arguments, then perform another clean build. clang --version should still print the correct revision information.

Event Timeline

modocache created this revision.Jul 7 2017, 11:14 AM
beanz accepted this revision.Aug 28 2017, 9:41 AM

Since the dependent patch landed, this LGTM too.

This revision is now accepted and ready to land.Aug 28 2017, 9:41 AM