Page MenuHomePhabricator

Clean up lldb-types.h
ClosedPublic

Authored by labath on Jul 7 2017, 2:35 AM.

Details

Summary

It defined a couple of types (condition_t) which we don't use anymore,
as we have c++11 goodies now. I remove these definitions.

Also it unnecessarily included a couple of headers which weren't
necessary for it's operation. I remove these, and place the includes in
the relevant files (usually .cpp, usually in Host code) which use them.
This allows us to reduce namespace pollution in most of the lldb files
which don't need the OS-specific definitions.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Jul 7 2017, 2:35 AM
krytarowski added inline comments.
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
18 ↗(On Diff #105603)

Is this needed here?

labath added inline comments.Jul 7 2017, 3:29 AM
source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
18 ↗(On Diff #105603)

good point. I'm pretty sure it isn't.

labath updated this revision to Diff 105613.Jul 7 2017, 3:29 AM

Remove unused include from auxvector.h

Eugene.Zelenko added inline comments.
include/lldb/Host/MainLoop.h
16 ↗(On Diff #105613)

I think will be good idea to include csignal instead. Same in other files. See http://clang.llvm.org/extra/clang-tidy/checks/modernize-deprecated-headers.html.

include/lldb/Host/MainLoop.h
16 ↗(On Diff #105613)

Good idea. I wasn't aware <csignal> existed.

labath updated this revision to Diff 105980.Jul 11 2017, 2:39 AM

Use csignal instead of signal.h

This revision was automatically updated to reflect the committed changes.