This is an archive of the discontinued LLVM Phabricator instance.

[COFF, AArch64] Set the private label prefix to .L
ClosedPublic

Authored by mstorsjo on Jul 6 2017, 12:32 PM.

Download Raw Diff

Details

Reviewers

compnerd
mgrang

Commits

rG68d0fcd7aaab: [COFF, AArch64] Set the private label prefix to .L
rL307317: [COFF, AArch64] Set the private label prefix to .L

Summary

This fixes calls to external functions starting with a capital L, fixing errors like this:
fatal error: error in backend: assembler label 'LocalFree' can not be undefined

Diff Detail

Repository: rL LLVM

Event Timeline

mstorsjo created this revision.Jul 6 2017, 12:32 PM

Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. · View Herald TranscriptJul 6 2017, 12:32 PM

LGTM.

This revision is now accepted and ready to land.Jul 6 2017, 12:38 PM

Closed by commit rL307317: [COFF, AArch64] Set the private label prefix to .L (authored by mstorsjo). · Explain WhyJul 6 2017, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

Target/

AArch64/

MCTargetDesc/

AArch64MCAsmInfo.cpp

2 lines

Diff 105528

llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines	AArch64MCAsmInfoELF::AArch64MCAsmInfoELF(const Triple &T) {

UseIntegratedAssembler = true;		UseIntegratedAssembler = true;

HasIdentDirective = true;		HasIdentDirective = true;
}		}

AArch64MCAsmInfoCOFF::AArch64MCAsmInfoCOFF() {		AArch64MCAsmInfoCOFF::AArch64MCAsmInfoCOFF() {
CommentString = ";";		CommentString = ";";
		PrivateGlobalPrefix = ".L";
		PrivateLabelPrefix = ".L";
}		}