Differential D34987

[AMDGPU] Fix regressions on mesa/clover with libclc due to address space
ClosedPublic
Actions

Authored by yaxunl on Jul 4 2017, 10:18 AM.

Details

Reviewers

tstellar
jvesely
awatry

Commits

rG3ba4a720adf6: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space
rC307105: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space
rL307105: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space

Summary

Currently AMDGPUTargetInfo does not initialize AddrSpaceMap in constructor, which causes regressions in mesa/clover with libclc.

This patch fixes that.

Diff Detail

Repository: rL LLVM

Event Timeline

yaxunl created this revision.Jul 4 2017, 10:18 AM

Herald added subscribers: t-tye, tpr, dstuttard and 2 others. · View Herald TranscriptJul 4 2017, 10:18 AM

Fix typo.

FWIW, this looks ok to me.

Just as importantly, this fixes the address space mapping regressions for both r600 (BARTS) and GCN/AMDGPU (PITCAIRN) for me.

This revision is now accepted and ready to land.Jul 4 2017, 12:16 PM

Closed by commit rL307105: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space (authored by yaxunl). · Explain WhyJul 4 2017, 12:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

cfe/

trunk/

lib/

Basic/

28 lines

test/

CodeGenOpenCL/

address-spaces.cl

2 lines

Diff 105196

cfe/trunk/lib/Basic/Targets.cpp

Loading...

cfe/trunk/test/CodeGenOpenCL/address-spaces.cl

Loading...