This is an archive of the discontinued LLVM Phabricator instance.

Move Timer and TraceOptions from Core to Utility
ClosedPublic

Authored by labath on Jun 28 2017, 3:15 AM.

Details

Summary

The classes have no dependencies, and they are used both by lldb and
lldb-server, so it makes sense for them to live in the lowest layers.

Event Timeline

labath created this revision.Jun 28 2017, 3:15 AM
zturner edited edge metadata.Jun 28 2017, 8:04 AM

Can you do a diff before and after of the analyze-deps script output? I don't imagine it will make a difference, but I've been surprised by it before. In general you should do it before and after every patch of this nature.

labath updated this revision to Diff 104624.Jun 29 2017, 5:52 AM

That's a good idea. This time I almost smuggled in a (unused) Host include into
Utility -- it was a leftover from the Host::ThreadLocalStorage times. I'll make
sure to run it in the future.

After fixing that issue, I see no differences in the output.

This revision was automatically updated to reflect the committed changes.
include/lldb/Utility/Timer.h