This is an archive of the discontinued LLVM Phabricator instance.

Differential D34384

Fix lld build error
ClosedPublic

Authored by sbc100 on Jun 19 2017, 10:04 PM.

Details

Reviewers
sunfish
Commits
rG1fb8daa69a62: Fix unused function build error in lld
rL305771: Fix unused function build error in lld
Summary

The lld-x86_64-darwin13 is failing with:
error: unused function 'operator<<'

Wrap the declation in ifndef NDEBUG, which matches
is done in MipsELFObjectWriter.cpp.

Diff Detail

Event Timeline

sbc100 created this revision.Jun 19 2017, 10:04 PM
Harbormaster completed remote builds in B7400: Diff 103148.Jun 19 2017, 10:04 PM
Herald added subscribers: aheejin, arichardson, sdardis. · View Herald TranscriptJun 19 2017, 10:04 PM
sbc100 added a reviewer: sunfish.Jun 19 2017, 10:04 PM
Closed by commit rL305771: Fix unused function build error in lld (authored by sbc). · Explain WhyJun 19 2017, 10:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
MC/
2 lines

Diff 103148

lib/MC/WasmObjectWriter.cpp

Show First 20 Lines • Show All 156 Lines • ▼ Show 20 Lines Out << "Off=" << Offset << ", Sym=" << Symbol << ", Addend=" << Addend
<< ", Type=" << Type << ", FixupSection=" << FixupSection; << ", Type=" << Type << ", FixupSection=" << FixupSection;
} }
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void dump() const { print(dbgs()); } LLVM_DUMP_METHOD void dump() const { print(dbgs()); }
#endif #endif
}; };
#if !defined(NDEBUG)
raw_ostream &operator<<(raw_ostream &OS, const WasmRelocationEntry &Rel) { raw_ostream &operator<<(raw_ostream &OS, const WasmRelocationEntry &Rel) {
Rel.print(OS); Rel.print(OS);
return OS; return OS;
} }
#endif
class WasmObjectWriter : public MCObjectWriter { class WasmObjectWriter : public MCObjectWriter {
/// Helper struct for containing some precomputed information on symbols. /// Helper struct for containing some precomputed information on symbols.
struct WasmSymbolData { struct WasmSymbolData {
const MCSymbolWasm *Symbol; const MCSymbolWasm *Symbol;
StringRef Name; StringRef Name;
// Support lexicographic sorting. // Support lexicographic sorting.
▲ Show 20 Lines • Show All 1,114 Lines • Show Last 20 Lines