Win64 SEH print register names

[yaron.keren]

Summary

Patch by Ray Donnelly to print register names instead of numbers.
Do not commit until Ray approves!

[mingwandroid]

Hi. I am the original author of this patch and am happy for our to be submitted for inclusion via this submission.

Best regards,

Ray Donnelly.

[chandlerc]

Please add the test case directly to this patch.

[yaron.keren]

With the updated test.

[grosbach]

LGTM

[yaron.keren]

Committed revision 206683.

[vadimcn]

This patch doesn't work right. I am seeing stuff like this in the emitted code:

	pushq	%rbp
	.seh_pushreg %rdi

Which, I guess, makes sense, because MCAsmStreamer::EmitRegisterName performs DWARF->LLVM register index mapping before emitting the name.

If you are gonna try to fix this, please not that .seh_... directives seem to use "SEH" register numbers, which are probably different from normal LLVM register indices.

lib/MC/MCAsmStreamer.cpp

 void MCAsmStreamer::EmitWin64EHPushReg(unsigned Register) {
   MCStreamer::EmitWin64EHPushReg(Register);
 
-  OS << "\t.seh_pushreg " << Register;
+  OS << "\t.seh_pushreg ";
+  EmitRegisterName(Register);
   EmitEOL();
 }
 

 void MCAsmStreamer::EmitWin64EHSetFrame(unsigned Register, unsigned Offset) {
   MCStreamer::EmitWin64EHSetFrame(Register, Offset);
 
-  OS << "\t.seh_setframe " << Register << ", " << Offset;
+  OS << "\t.seh_setframe ";
+  EmitRegisterName(Register);
+  OS << ", " << Offset;
   EmitEOL();
 }
 

 void MCAsmStreamer::EmitWin64EHSaveReg(unsigned Register, unsigned Offset) {
   MCStreamer::EmitWin64EHSaveReg(Register, Offset);
 
-  OS << "\t.seh_savereg " << Register << ", " << Offset;
+  OS << "\t.seh_savereg ";
+  EmitRegisterName(Register);
+  OS << ", " << Offset;
   EmitEOL();
 }
 

 void MCAsmStreamer::EmitWin64EHSaveXMM(unsigned Register, unsigned Offset) {
   MCStreamer::EmitWin64EHSaveXMM(Register, Offset);
 
-  OS << "\t.seh_savexmm " << Register << ", " << Offset;
+  OS << "\t.seh_savexmm ";
+  EmitRegisterName(Register);
+  OS << ", " << Offset;
   EmitEOL();
 }
 

test/MC/AsmParser/directive_seh.s

 # CHECK: .seh_proc func
 # CHECK: .seh_pushframe @code
 # CHECK: .seh_stackalloc 24
-# CHECK: .seh_savereg 6, 16
-# CHECK: .seh_savexmm 8, 0
-# CHECK: .seh_pushreg 3
-# CHECK: .seh_setframe 3, 0
+# CHECK: .seh_savereg %rbp, 16
+# CHECK: .seh_savexmm %r8, 0
+# CHECK: .seh_pushreg %rbx
+# CHECK: .seh_setframe %rbx, 0
 # CHECK: .seh_endprologue
 # CHECK: .seh_handler __C_specific_handler, @except
 # CHECK-NOT: .section{{.*}}.xdata