Page MenuHomePhabricator

Win64 SEH print register names
ClosedPublic

Authored by yaron.keren on Apr 18 2014, 5:20 AM.

Details

Summary

Patch by Ray Donnelly to print register names instead of numbers.
Do not commit until Ray approves!

Diff Detail

Event Timeline

Hi. I am the original author of this patch and am happy for our to be submitted for inclusion via this submission.

Best regards,

Ray Donnelly.

Please add the test case directly to this patch.

yaron.keren updated this revision to Unknown Object (????).Apr 18 2014, 1:38 PM

With the updated test.

yaron.keren closed this revision.Apr 18 2014, 10:47 PM

Committed revision 206683.

vadimcn edited edge metadata.May 2 2014, 5:24 PM

This patch doesn't work right. I am seeing stuff like this in the emitted code:

	pushq	%rbp
	.seh_pushreg %rdi

Which, I guess, makes sense, because MCAsmStreamer::EmitRegisterName performs DWARF->LLVM register index mapping before emitting the name.

If you are gonna try to fix this, please not that .seh_... directives seem to use "SEH" register numbers, which are probably different from normal LLVM register indices.