This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][builtins] Better Fuchsia support
ClosedPublic

Authored by phosek on Jun 9 2017, 7:43 PM.

Details

Summary

Add Fuchsia support to some builtins and avoid building builtins that are not and will never be used on Fuchsia.

Diff Detail

Event Timeline

phosek created this revision.Jun 9 2017, 7:43 PM
compnerd accepted this revision.Jun 9 2017, 9:40 PM
compnerd added a subscriber: compnerd.
compnerd added inline comments.
lib/builtins/CMakeLists.txt
227

eprintf is a darwin specific thing, not to be added everywhere. Is this still being filtered out?

lib/builtins/int_util.c
50

Please use the reserved spellings of the attributes.

This revision is now accepted and ready to land.Jun 9 2017, 9:40 PM
jroelofs added inline comments.Jun 12 2017, 7:16 AM
lib/builtins/CMakeLists.txt
227

Feel free to stick eprintf.c in the "not on baremetal section", too.

phosek updated this revision to Diff 102466.Jun 13 2017, 6:00 PM
phosek marked an inline comment as done.
phosek added inline comments.
lib/builtins/CMakeLists.txt
227

Should it be that one or the APPLE one?

This revision was automatically updated to reflect the committed changes.
jroelofs added inline comments.Jul 12 2017, 12:42 PM
compiler-rt/trunk/lib/builtins/int_util.c
50 ↗(On Diff #106281)

Can __Fuscia__ && defined(_WIN32) ever be true?