This is an archive of the discontinued LLVM Phabricator instance.

Bitcode: Write the irsymtab to disk.
ClosedPublic

Authored by pcc on Jun 6 2017, 5:59 PM.

Event Timeline

pcc created this revision.Jun 6 2017, 5:59 PM
tejohnson accepted this revision.Jun 26 2017, 7:48 PM

LGTM

llvm/include/llvm/Bitcode/BitcodeWriter.h
31

Document what this is used for.

llvm/test/Object/X86/irsymtab.ll
5

Can you note what offset into this dump holds the symtab version so that it is more obvious which needs to be adjusted whenever that gets bumped?

This revision is now accepted and ready to land.Jun 26 2017, 7:48 PM
pcc updated this revision to Diff 104279.Jun 27 2017, 2:45 PM
pcc marked 2 inline comments as done.
  • Address review comments
This revision was automatically updated to reflect the committed changes.