This is an archive of the discontinued LLVM Phabricator instance.

[libunwind][CMake] Add install path variable to allow overriding the destination
ClosedPublic

Authored by phosek on Jun 1 2017, 12:46 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Jun 1 2017, 12:46 AM
srhines added a subscriber: srhines.Jun 1 2017, 6:27 AM
phosek updated this revision to Diff 103695.Jun 23 2017, 12:15 AM
phosek updated this revision to Diff 104522.Jun 28 2017, 3:11 PM
pirama added a subscriber: pirama.Jul 6 2017, 3:52 PM
beanz added inline comments.Jul 7 2017, 10:10 AM
CMakeLists.txt
167 ↗(On Diff #104522)

We need to have some enforcement that this is either empty or ends in "/" otherwise the behavior will be unintuitive. If you add that to all three of the patches this will be good.

That enforcement could be something like I sent you a while back, or it could be a CMake error. I just want to make it hard to misuse this feature.

phosek updated this revision to Diff 105689.Jul 7 2017, 2:09 PM
phosek marked an inline comment as done.
phosek added a comment.Jul 7 2017, 4:42 PM

@beanz I've added the error check in all three patches, can you take a look again?

beanz accepted this revision.Jul 10 2017, 9:22 AM

LGTM!

This revision is now accepted and ready to land.Jul 10 2017, 9:22 AM
This revision was automatically updated to reflect the committed changes.