This is an archive of the discontinued LLVM Phabricator instance.

Differential D33691

AMDGPU/LLD: Remove deprecated and unused elf definitions from tests
ClosedPublic

Authored by kzhuravl on May 30 2017, 1:28 PM.

Details

Reviewers
arsenm
t-tye
tstellar
Commits
rG4c882d90aad6: AMDGPU/LLD: Remove deprecated and unused elf definitions from tests
rLLD304734: AMDGPU/LLD: Remove deprecated and unused elf definitions from tests
rL304734: AMDGPU/LLD: Remove deprecated and unused elf definitions from tests

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl created this revision.May 30 2017, 1:28 PM
Herald added subscribers: tpr, dstuttard, yaxunl and 3 others. · View Herald TranscriptMay 30 2017, 1:28 PM
kzhuravl updated this revision to Diff 100909.May 31 2017, 12:54 PM
  • Restore original run lines
  • Restore phdr checking
kzhuravl added a comment.Jun 5 2017, 8:38 AM

Ping.

t-tye accepted this revision.Jun 5 2017, 1:11 PM

LGTM

This revision is now accepted and ready to land.Jun 5 2017, 1:11 PM
Closed by commit rL304734: AMDGPU/LLD: Remove deprecated and unused elf definitions from tests (authored by kzhuravl). · Explain WhyJun 5 2017, 1:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
test/
ELF/
148 lines
16 lines

Diff 101457

lld/trunk/test/ELF/amdgpu-globals.s

# RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=kaveri %s -o %t.o # RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=kaveri %s -o %t.o
# RUN: ld.lld %t.o -o %t # RUN: ld.lld -shared %t.o -o %t
# RUN: llvm-readobj -sections -symbols -program-headers %t | FileCheck %s # RUN: llvm-readobj -sections -symbols -program-headers %t | FileCheck %s
# REQUIRES: amdgpu # REQUIRES: amdgpu
.amdgpu_hsa_module_global module_global_program .type glob0, @object
.size module_global_program, 4 .data
.hsadata_global_program .globl glob0
module_global_program: glob0:
.long 0 ; 0x0 .long 1
.size glob0, 4
.amdgpu_hsa_program_global program_global_program
.size program_global_program, 4 .type glob1, @object
.hsadata_global_program .section .rodata, #alloc
program_global_program: .globl glob1
.long 0 ; 0x0 glob1:
.long 2
.amdgpu_hsa_module_global module_global_agent .size glob1, 4
.size module_global_agent, 4
.hsadata_global_agent
module_global_agent:
.long 0 ; 0x0
.amdgpu_hsa_program_global program_global_agent
.size program_global_agent, 4
.hsadata_global_agent
program_global_agent:
.long 0 ; 0x0
.amdgpu_hsa_module_global module_global_readonly
.size module_global_readonly, 4
.hsatext
module_global_readonly:
.long 0 ; 0x0
.amdgpu_hsa_program_global program_global_readonly
.size program_global_readonly, 4
.hsatext
program_global_readonly:
.long 0 ; 0x0
# CHECK: Section { # CHECK: Section {
# CHECK: Name: .hsatext # CHECK: Name: .rodata
# CHECK: Type: SHT_PROGBITS # CHECK: Type: SHT_PROGBITS
# CHECK: Flags [ (0xC00007) # CHECK: Flags [ (0x2)
# CHECK: SHF_ALLOC (0x2) # CHECK: SHF_ALLOC (0x2)
# CHECK: SHF_AMDGPU_HSA_AGENT (0x800000)
# CHECK: SHF_AMDGPU_HSA_CODE (0x400000)
# CHECK: SHF_EXECINSTR (0x4)
# CHECK: SHF_WRITE (0x1)
# CHECK: ]
# CHECK: Address: [[HSATEXT_ADDR:[0-9xa-f]+]]
# CHECK: }
# CHECK: Section {
# CHECK: Name: .hsadata_global_program
# CHECK: Type: SHT_PROGBITS (0x1)
# CHECK: Flags [ (0x100003)
# CHECK: SHF_ALLOC (0x2)
# CHECK: SHF_AMDGPU_HSA_GLOBAL (0x100000)
# CHECK: SHF_WRITE (0x1)
# CHECK: ] # CHECK: ]
# CHECK: Address: [[HSADATA_GLOBAL_PROGRAM_ADDR:[0-9xa-f]+]] # CHECK: Address: [[RODATA_ADDR:[0-9xa-f]+]]
# CHECK: } # CHECK: }
# CHECK: Section { # CHECK: Section {
# CHECK: Name: .hsadata_global_agent # CHECK: Name: .data
# CHECK: Type: SHT_PROGBITS (0x1) # CHECK: Type: SHT_PROGBITS
# CHECK: Flags [ (0x900003) # CHECK: Flags [ (0x3)
# CHECK: SHF_ALLOC (0x2) # CHECK: SHF_ALLOC (0x2)
# CHECK: SHF_AMDGPU_HSA_AGENT (0x800000)
# CHECK: SHF_AMDGPU_HSA_GLOBAL (0x100000)
# CHECK: SHF_WRITE (0x1) # CHECK: SHF_WRITE (0x1)
# CHECK: ] # CHECK: ]
# CHECK: Address: [[DATA_ADDR:[0-9xa-f]+]]
# CHECK: } # CHECK: }
# CHECK: Symbol { # CHECK: Symbol {
# CHECK: Name: module_global_agent # CHECK: Name: glob0
# CHECK: Value: # CHECK: Value: [[DATA_ADDR]]
# CHECK: Size: 4
# CHECK: Binding: Local
# CHECK: Section: .hsadata_global_agent
# CHECK: }
# CHECK: Symbol {
# CHECK: Name: module_global_program
# CHECK: Value:
# CHECK: Size: 4
# CHECK: Binding: Local
# CHECK: Section: .hsadata_global_program
# CHECK: }
# CHECK: Symbol {
# CHECK: Name: module_global_readonly
# CHECK: Value:
# CHECK: Size: 4
# CHECK: Binding: Local
# CHECK: Type: Object
# CHECK: Section: .hsatext
# CHECK: }
# CHECK: Symbol {
# CHECK: Name: program_global_agent
# CHECK: Value:
# CHECK: Size: 4
# CHECK: Binding: Global
# CHECK: Type: Object
# CHECK: Section: .hsadata_global_agent
# CHECK: }
# CHECK: Symbol {
# CHECK: Name: program_global_program
# CHECK: Value:
# CHECK: Size: 4 # CHECK: Size: 4
# CHECK: Binding: Global
# CHECK: Type: Object # CHECK: Type: Object
# CHECK: Section: .hsadata_global_program # CHECK: Section: .data
# CHECK: } # CHECK: }
# CHECK: Symbol { # CHECK: Symbol {
# CHECK: Name: program_global_readonly # CHECK: Name: glob1
# CHECK: Value: # CHECK: Value: [[RODATA_ADDR]]
# CHECK: Size: 4 # CHECK: Size: 4
# CHECK: Binding: Global
# CHECK: Type: Object # CHECK: Type: Object
# CHECK: Section: .hsatext # CHECK: Section: .rodata
# CHECK: } # CHECK: }
# CHECK: ProgramHeader { # CHECK: ProgramHeader {
# CHECK: Type: PT_LOAD # CHECK: Type: PT_LOAD
# CHECK: VirtualAddress: # CHECK: VirtualAddress:
# CHECK: } # CHECK: }
# CHECK: ProgramHeader { # CHECK: ProgramHeader {
# CHECK: Type: PT_LOAD # CHECK: Type: PT_LOAD
# CHECK: VirtualAddress: # CHECK: VirtualAddress:
# CHECK: } # CHECK: }

lld/trunk/test/ELF/amdgpu-kernels.s

# RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=kaveri %s -o %t.o # RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=kaveri %s -o %t.o
# RUN: ld.lld %t.o -o %t # RUN: ld.lld -shared %t.o -o %t
# RUN: llvm-readobj -sections -symbols -program-headers %t | FileCheck %s # RUN: llvm-readobj -sections -symbols -program-headers %t | FileCheck %s
# REQUIRES: amdgpu # REQUIRES: amdgpu
.hsa_code_object_version 1,0 .hsa_code_object_version 1,0
.hsa_code_object_isa 7,0,0,"AMD","AMDGPU" .hsa_code_object_isa 7,0,0,"AMD","AMDGPU"
.hsatext .text
.globl kernel0 .globl kernel0
.align 256 .align 256
.amdgpu_hsa_kernel kernel0 .amdgpu_hsa_kernel kernel0
kernel0: kernel0:
s_endpgm s_endpgm
.Lfunc_end0: .Lfunc_end0:
.size kernel0, .Lfunc_end0-kernel0 .size kernel0, .Lfunc_end0-kernel0
.globl kernel1 .globl kernel1
.align 256 .align 256
.amdgpu_hsa_kernel kernel1 .amdgpu_hsa_kernel kernel1
kernel1: kernel1:
s_endpgm s_endpgm
s_endpgm s_endpgm
.Lfunc_end1: .Lfunc_end1:
.size kernel1, .Lfunc_end1-kernel1 .size kernel1, .Lfunc_end1-kernel1
# CHECK: Section { # CHECK: Section {
# CHECK: Name: .hsatext # CHECK: Name: .text
# CHECK: Type: SHT_PROGBITS # CHECK: Type: SHT_PROGBITS
# CHECK: Flags [ (0xC00007) # CHECK: Flags [ (0x6)
# CHECK: SHF_ALLOC (0x2) # CHECK: SHF_ALLOC (0x2)
# CHECK: SHF_AMDGPU_HSA_AGENT (0x800000)
# CHECK: SHF_AMDGPU_HSA_CODE (0x400000)
# CHECK: SHF_EXECINSTR (0x4) # CHECK: SHF_EXECINSTR (0x4)
# CHECK: SHF_WRITE (0x1)
# CHECK: ] # CHECK: ]
# CHECK: Address: [[HSATEXT_ADDR:[0-9xa-f]+]]
# CHECK: } # CHECK: }
# CHECK: Symbol { # CHECK: Symbol {
# CHECK: Name: kernel0 # CHECK: Name: kernel0
# CHECK: Value: # CHECK: Value:
# CHECK: Size: 4 # CHECK: Size: 4
# CHECK: Binding: Global # CHECK: Binding: Global
# CHECK: Type: AMDGPU_HSA_KERNEL # CHECK: Type: AMDGPU_HSA_KERNEL
# CHECK: Section: .hsatext # CHECK: Section: .text
# CHECK: } # CHECK: }
# CHECK: Symbol { # CHECK: Symbol {
# CHECK: Name: kernel1 # CHECK: Name: kernel1
# CHECK: Value: # CHECK: Value:
# CHECK: Size: 8 # CHECK: Size: 8
# CHECK: Binding: Global # CHECK: Binding: Global
# CHECK: Type: AMDGPU_HSA_KERNEL # CHECK: Type: AMDGPU_HSA_KERNEL
# CHECK: Section: .hsatext # CHECK: Section: .text
# CHECK: } # CHECK: }
# CHECK: ProgramHeader { # CHECK: ProgramHeader {
# CHECK: Type: PT_LOAD # CHECK: Type: PT_LOAD
# CHECK: VirtualAddress: # CHECK: VirtualAddress:
# CHECK: } # CHECK: }