Running unittests/Support/DynamicLibrary/DynamicLibraryTests fails when LLVM is configured with LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON, because the test's version script only contains symbols
extracted from the static libraries, that the test links with, but not those from the main object/executable itself. The patch
explicitly exports the one symbol needed by the test.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Looks fine as long as you're confident this doesn't interfere when built without LLVM_EXPORT_SYMBOLS_FOR_PLUGINS.
Comment Actions
Yes, regardless of the state of LLVM_EXPORT_SYMBOLS_FOR_PLUGINS, the build uses the given symbols list instead of
exporting all the symbols or exporting whatever symbols extract_symbols.py decides to export.
Comment Actions
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5220 seem to be unhappy about this change.
Comment Actions
Ok, I will revert this one. @chill will suggest another solution. Sorry for the fuss.