- User Since
- Jul 25 2016, 10:43 PM (164 w, 6 d)
Apr 13 2019
Sorry for the tardiness of this...
- Could the the type change from std::string be to the new State type introduced (rather than int)
- Have all State variables default initialized to a value that would cause the test to fail.
Nov 27 2018
Crap your right...I might revisit this (as I think that's a bad move on my part).
I'd still like to give a moment for anyone else to chime in; otherwise, it shouldn't be a reason to hold this up.
Nov 22 2018
@lhames, any thoughts?
I take it your using the MSVC generator?
I use ninja (which is a single-config build) all the time and it puts the the files into unittests/Support/DynamicLibrary ?
I'll try to spin up a Windows build in the next couple of days, but I'm not foreseeing my opinion being changed.
Nov 19 2018
I'm not a fan of writing test stuff into <buildroot>/lib.
Sep 9 2018
Just maybe add a comment similar to the last line of the summary
Mar 19 2018
Mar 17 2018
Sorry 'bout that...
(CMake and quoting make dull boys)
Mar 15 2018
Shouldn't the Translation Unit be responsible for knowing what it needs rather than hoping it's already been used somewhere up the chain.
Perhaps std::unique_ptr and std::make_pair are too low level and one can assume, but D44509 seems like a possibly overzealous application?
Mar 14 2018
Feb 27 2018
Feb 25 2018
I think what you're trying to do just isn't unsupported at this time.
Why not just use the JIT to compile the source for the on disk object at runtime?
Feb 22 2018
It's a little hard to understand the issue. To be clear:
This patch is fixing an instance that used to crash?
However there is a bit of manual setup for the JIT you are still not happy with?
Feb 21 2018
Just waiting till I had a moment to watch the new test on the bots.
Feb 18 2018
Changed name of function to write32BitOffset.
Feb 17 2018
Feb 16 2018
Feb 15 2018
Added test case for IMAGE_REL_AMD64_ADDR32NB with JIT and requested formatting changes.
Dec 11 2017
Aug 14 2017
I can commit this, but it should probably be merged into release_50 as well (?)
Aug 3 2017
Aug 2 2017
Aug 1 2017
I'm wondering if the #ifdef is now a dead code path entirely.
Do you have any insight into how ARM is getting __atomic_load_n and x86/64 not?
Jul 30 2017
Jul 28 2017
Done, thanks. Would it be possible to look at D30709 as this depends on that. (ELF does not like Windows exceptions).
Use include guards, not pragma once and remove commented CMake debug lines.
Jul 24 2017
Jul 18 2017
Jul 13 2017
Done, and changed to 'windows.h', but blocked mingw from even attempting SEH for now.
Blocked Win64 SEH for MingW entirely.
Theoretically it should be possible to throw a SEH from within mingw, but but I'm thinking clang may be generating exception handlers for the gcc runtime in that case.
I'll leave it up to someone with interest in such a mixture to figure that tout.
Added support for IEC, SI, and Customary output.
@joerg Any further thoughts/desire to review this?
Finishing this off would be nice and at least opens the door to using RTLD_LOCAL.
Jul 12 2017
What about an optional argument to specific IEC suffixes.
Using IEC by default is fine by me, just that there is a way to not do so.
@lhames Is there any chance to get this in before 5.0...it removes the need to store this same exact information 2x in our code base.
Jul 11 2017
I appreciate the differences, but this is specifically to output an amount of memory in a human readable form.
Using KiB, MiB, etc may be pedantically correct, but it limits the usefulness of this to format text for a user who may have little knowledge of the differences between SI and IEC suffixes.
Every operating system I'm aware of does it this way and having output correlate to how the OS reports memory is more important.
Fix typo in documentation.
Jul 9 2017
Use to std::pair instead of PointerIntPair, it's lighter for the temporary.
Jul 7 2017
Jul 6 2017
This has nothing to do with fixing your issue and is solely to allow clients to load via RTLD_LOCAL.
I don't see how D33529 could have broken anything as it is not committed yet. D33529 attempts to address what I understand is your issue.
If it's not working perhaps you could explain or provide a bit more info what doesn't work...(on that thread not here).
Perhaps @pcanal can help with that?
Typo & reword documentation.
From what I can tell, in LLVM the clients of this are solely clang and lldb.
Nothing should break for them as they explicitly search single libraries for symbols.