- User Since
- Jul 25 2016, 10:43 PM (72 w, 1 d)
Mon, Dec 11
Aug 14 2017
I can commit this, but it should probably be merged into release_50 as well (?)
Aug 3 2017
Aug 2 2017
Aug 1 2017
I'm wondering if the #ifdef is now a dead code path entirely.
Do you have any insight into how ARM is getting __atomic_load_n and x86/64 not?
Jul 30 2017
Jul 28 2017
Done, thanks. Would it be possible to look at D30709 as this depends on that. (ELF does not like Windows exceptions).
Use include guards, not pragma once and remove commented CMake debug lines.
Jul 24 2017
Jul 18 2017
Jul 13 2017
Done, and changed to 'windows.h', but blocked mingw from even attempting SEH for now.
Blocked Win64 SEH for MingW entirely.
Theoretically it should be possible to throw a SEH from within mingw, but but I'm thinking clang may be generating exception handlers for the gcc runtime in that case.
I'll leave it up to someone with interest in such a mixture to figure that tout.
Added support for IEC, SI, and Customary output.
@joerg Any further thoughts/desire to review this?
Finishing this off would be nice and at least opens the door to using RTLD_LOCAL.
Jul 12 2017
What about an optional argument to specific IEC suffixes.
Using IEC by default is fine by me, just that there is a way to not do so.
@lhames Is there any chance to get this in before 5.0...it removes the need to store this same exact information 2x in our code base.
Jul 11 2017
I appreciate the differences, but this is specifically to output an amount of memory in a human readable form.
Using KiB, MiB, etc may be pedantically correct, but it limits the usefulness of this to format text for a user who may have little knowledge of the differences between SI and IEC suffixes.
Every operating system I'm aware of does it this way and having output correlate to how the OS reports memory is more important.
Fix typo in documentation.
Jul 9 2017
Use to std::pair instead of PointerIntPair, it's lighter for the temporary.
Jul 7 2017
Jul 6 2017
This has nothing to do with fixing your issue and is solely to allow clients to load via RTLD_LOCAL.
I don't see how D33529 could have broken anything as it is not committed yet. D33529 attempts to address what I understand is your issue.
If it's not working perhaps you could explain or provide a bit more info what doesn't work...(on that thread not here).
Perhaps @pcanal can help with that?
Typo & reword documentation.
From what I can tell, in LLVM the clients of this are solely clang and lldb.
Nothing should break for them as they explicitly search single libraries for symbols.
Jul 5 2017
Works fine here against master, though D33658 did have a conflict.
Include PointerIntPair.h for modules build & resolved conflict.
Jun 19 2017
Jun 14 2017
From the summary:
Fixes an issue using RegisterStandardPasses from a statically linked object before PassManagerBuilder::addGlobalExtension is called from a dynamic library.
I'm missing the *why* using a "real function" (I guess you meant "function pointer") matter?
Remove spurious newline.
This should be more 'obviously' correct.
Sorry, some CMake confusion here....
Relocate tests into Transforms/IPO.
Jun 13 2017
Having trouble with the test part of this and CMake.
Add explicit dependency for CMake when built with LLVM_ENABLE_MODULES.
Conflict resolution & additional comment.