marsupial (Frederich Munch)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 10:43 PM (63 w, 6 d)

Recent Activity

Aug 14 2017

marsupial committed rL310906: Propagate error in LazyEmittingLayer::removeModule..
Propagate error in LazyEmittingLayer::removeModule.
Aug 14 2017, 7:28 PM
marsupial closed D36700: Propagate error in LazyEmittingLayer::removeModule. by committing rL310906: Propagate error in LazyEmittingLayer::removeModule..
Aug 14 2017, 7:28 PM
marsupial added a dependency for D36702: Make Parser::Consume*Token methods public.: D36701: Use Token::isOneOf method in Parser..
Aug 14 2017, 11:16 AM
marsupial added a dependent revision for D36701: Use Token::isOneOf method in Parser.: D36702: Make Parser::Consume*Token methods public..
Aug 14 2017, 11:16 AM
marsupial created D36702: Make Parser::Consume*Token methods public..
Aug 14 2017, 11:15 AM
marsupial created D36701: Use Token::isOneOf method in Parser..
Aug 14 2017, 11:11 AM
marsupial added a comment to D36700: Propagate error in LazyEmittingLayer::removeModule..

I can commit this, but it should probably be merged into release_50 as well (?)

Aug 14 2017, 11:04 AM
marsupial created D36700: Propagate error in LazyEmittingLayer::removeModule..
Aug 14 2017, 10:45 AM

Aug 3 2017

marsupial accepted D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.

LGTM.

Aug 3 2017, 10:15 AM

Aug 2 2017

marsupial added inline comments to D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.
Aug 2 2017, 12:55 PM
marsupial added inline comments to D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.
Aug 2 2017, 6:29 AM

Aug 1 2017

marsupial added a comment to D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.

I'm wondering if the #ifdef is now a dead code path entirely.
Do you have any insight into how ARM is getting __atomic_load_n and x86/64 not?

Aug 1 2017, 7:26 PM

Jul 30 2017

marsupial added inline comments to D30787: [builtins] Implement emulated TLS on Windows..
Jul 30 2017, 10:01 PM

Jul 28 2017

marsupial added a comment to D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Done, thanks. Would it be possible to look at D30709 as this depends on that. (ELF does not like Windows exceptions).

Jul 28 2017, 10:26 AM
marsupial updated the diff for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Use include guards, not pragma once and remove commented CMake debug lines.

Jul 28 2017, 10:23 AM

Jul 24 2017

marsupial added a comment to D33658: Extend DynamicLibrary class to be usable without loading permanently..

Ping,

Jul 24 2017, 1:58 PM
marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

Ping,

Jul 24 2017, 1:58 PM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Ping.

Jul 24 2017, 1:58 PM
marsupial added a comment to D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Ping.

Jul 24 2017, 1:57 PM
marsupial added a comment to D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

Ping.

Jul 24 2017, 1:57 PM

Jul 18 2017

marsupial retitled D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string. from Support: Add llvm::format_memory to convert number of bytes to human readable string. to Support: Add llvm::format_memory_size to convert number of bytes to human readable string..
Jul 18 2017, 8:53 AM
marsupial committed rL308321: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Make EHFrames available to sub-classes of RTDyldMemoryManager.
Jul 18 2017, 8:51 AM
marsupial closed D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager. by committing rL308321: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 18 2017, 8:51 AM

Jul 13 2017

marsupial added a comment to D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Done, and changed to 'windows.h', but blocked mingw from even attempting SEH for now.

Jul 13 2017, 3:24 PM
marsupial updated the diff for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Blocked Win64 SEH for MingW entirely.
Theoretically it should be possible to throw a SEH from within mingw, but but I'm thinking clang may be generating exception handlers for the gcc runtime in that case.
I'll leave it up to someone with interest in such a mixture to figure that tout.

Jul 13 2017, 3:22 PM
marsupial updated the diff for D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

Added support for IEC, SI, and Customary output.

Jul 13 2017, 11:24 AM
marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

@joerg Any further thoughts/desire to review this?
Finishing this off would be nice and at least opens the door to using RTLD_LOCAL.

Jul 13 2017, 9:15 AM
marsupial committed rL307922: Support: Add llvm::center_justify..
Support: Add llvm::center_justify.
Jul 13 2017, 9:11 AM
marsupial closed D35278: Support: Add llvm::center_justify. by committing rL307922: Support: Add llvm::center_justify..
Jul 13 2017, 9:11 AM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

@compnerd is it possible to restart this.
I added an example to clang that verifies this works in D35103.
Just don't know how to trigger the relocation types in LLVM.

Jul 13 2017, 7:19 AM

Jul 12 2017

marsupial committed rL307849: Allow clients to specify search order of DynamicLibraries..
Allow clients to specify search order of DynamicLibraries.
Jul 12 2017, 2:23 PM
marsupial closed D33529: Allow clients to specify search order of DynamicLibraries. by committing rL307849: Allow clients to specify search order of DynamicLibraries..
Jul 12 2017, 2:23 PM
marsupial added a comment to D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

@ruiu
What about an optional argument to specific IEC suffixes.
Using IEC by default is fine by me, just that there is a way to not do so.

Jul 12 2017, 11:57 AM
marsupial added a comment to D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..

Ping.
@lhames Is there any chance to get this in before 5.0...it removes the need to store this same exact information 2x in our code base.

Jul 12 2017, 9:51 AM

Jul 11 2017

marsupial added a comment to D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

I appreciate the differences, but this is specifically to output an amount of memory in a human readable form.
Using KiB, MiB, etc may be pedantically correct, but it limits the usefulness of this to format text for a user who may have little knowledge of the differences between SI and IEC suffixes.
Every operating system I'm aware of does it this way and having output correlate to how the OS reports memory is more important.

Jul 11 2017, 8:02 PM
marsupial updated the diff for D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

Fix typo in documentation.

Jul 11 2017, 5:43 PM
marsupial created D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..
Jul 11 2017, 5:41 PM
marsupial updated the diff for D35278: Support: Add llvm::center_justify..

Updated

Jul 11 2017, 4:44 PM
marsupial updated the diff for D35278: Support: Add llvm::center_justify..
Jul 11 2017, 4:35 PM
marsupial added a comment to D35278: Support: Add llvm::center_justify..

Ok,

Jul 11 2017, 4:01 PM
marsupial updated the diff for D35278: Support: Add llvm::center_justify..
Jul 11 2017, 4:01 PM
marsupial created D35278: Support: Add llvm::center_justify..
Jul 11 2017, 3:05 PM

Jul 9 2017

marsupial updated the diff for D33658: Extend DynamicLibrary class to be usable without loading permanently..

Use to std::pair instead of PointerIntPair, it's lighter for the temporary.

Jul 9 2017, 6:13 AM

Jul 7 2017

marsupial added a comment to D33529: Allow clients to specify search order of DynamicLibraries..

@v.g.vassilev @pcanal :
Can you provide a concrete example of a test in ROOT that this patch does not solve?

Jul 7 2017, 7:13 AM

Jul 6 2017

marsupial added dependencies for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager., D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Jul 6 2017, 9:18 PM
marsupial added a dependent revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial added a dependent revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial removed dependent revisions for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF, D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:18 PM
marsupial removed a dependency for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial removed a dependency for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial added a dependency for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:17 PM
marsupial added dependent revisions for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager., D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Jul 6 2017, 9:17 PM
marsupial added a dependency for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:17 PM
marsupial removed dependencies for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF, D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:16 PM
marsupial removed a dependent revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:16 PM
marsupial removed a dependent revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:16 PM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Ping.

Jul 6 2017, 9:12 PM
marsupial added a dependency for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Jul 6 2017, 9:12 PM
marsupial added a dependent revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:12 PM
marsupial added a dependent revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:12 PM
marsupial added a dependency for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:12 PM
marsupial created D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:11 PM
marsupial created D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:06 PM
marsupial updated subscribers of D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

This has nothing to do with fixing your issue and is solely to allow clients to load via RTLD_LOCAL.
I don't see how D33529 could have broken anything as it is not committed yet. D33529 attempts to address what I understand is your issue.
If it's not working perhaps you could explain or provide a bit more info what doesn't work...(on that thread not here).
Perhaps @pcanal can help with that?

Jul 6 2017, 7:50 PM
marsupial updated the diff for D33529: Allow clients to specify search order of DynamicLibraries..

Typo & reword documentation.

Jul 6 2017, 7:27 PM
marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

From what I can tell, in LLVM the clients of this are solely clang and lldb.
Nothing should break for them as they explicitly search single libraries for symbols.

Jul 6 2017, 11:10 AM
marsupial added a comment to D33659: Extend DynamicLibrary class to be usable without loading permanently..

ping

Jul 6 2017, 10:23 AM
marsupial updated the diff for D33659: Extend DynamicLibrary class to be usable without loading permanently..
Jul 6 2017, 10:22 AM
marsupial added a dependent revision for D33658: Extend DynamicLibrary class to be usable without loading permanently.: D35070: Extend DynamicLibrary class to be usable without loading permanently..
Jul 6 2017, 10:17 AM
marsupial added a dependency for D35070: Extend DynamicLibrary class to be usable without loading permanently.: D33658: Extend DynamicLibrary class to be usable without loading permanently..
Jul 6 2017, 10:17 AM
marsupial created D35070: Extend DynamicLibrary class to be usable without loading permanently..
Jul 6 2017, 10:15 AM

Jul 5 2017

marsupial committed rL307229: Avoid constructing GlobalExtensions only to find out it is empty..
Avoid constructing GlobalExtensions only to find out it is empty.
Jul 5 2017, 5:09 PM
marsupial closed D33381: Avoid constructing GlobalExtensions only to find out it is empty. by committing rL307229: Avoid constructing GlobalExtensions only to find out it is empty..
Jul 5 2017, 5:09 PM
marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

Works fine here against master, though D33658 did have a conflict.

Jul 5 2017, 4:37 PM
marsupial updated the diff for D33658: Extend DynamicLibrary class to be usable without loading permanently..

Include PointerIntPair.h for modules build & resolved conflict.

Jul 5 2017, 4:36 PM

Jun 19 2017

marsupial added a comment to D33658: Extend DynamicLibrary class to be usable without loading permanently..

Ping.

Jun 19 2017, 8:21 AM
marsupial added a comment to D33381: Avoid constructing GlobalExtensions only to find out it is empty..

Ping.

Jun 19 2017, 8:20 AM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Ping.

Jun 19 2017, 8:19 AM
marsupial added a comment to D33529: Allow clients to specify search order of DynamicLibraries..

Ping.

Jun 19 2017, 8:19 AM

Jun 14 2017

marsupial updated the summary of D33515: Force RegisterStandardPasses to construct std::function in the IPO library..
Jun 14 2017, 5:17 PM
marsupial added a comment to D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

From the summary:

Fixes an issue using RegisterStandardPasses from a statically linked object before PassManagerBuilder::addGlobalExtension is called from a dynamic library.

Jun 14 2017, 4:05 PM
marsupial updated the diff for D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

Format.

Jun 14 2017, 12:28 PM
marsupial committed rL305408: Hide dbgs() stream for when built with -fmodules..
Hide dbgs() stream for when built with -fmodules.
Jun 14 2017, 12:17 PM
marsupial closed D34214: Hide dbgs() stream for when built with -fmodules. by committing rL305408: Hide dbgs() stream for when built with -fmodules..
Jun 14 2017, 12:16 PM
marsupial added a comment to D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

I'm missing the *why* using a "real function" (I guess you meant "function pointer") matter?

Jun 14 2017, 12:16 PM
marsupial updated the diff for D34214: Hide dbgs() stream for when built with -fmodules..

Remove spurious newline.

Jun 14 2017, 11:48 AM
marsupial updated the diff for D34214: Hide dbgs() stream for when built with -fmodules..

Formatting.

Jun 14 2017, 11:45 AM
marsupial updated the diff for D34214: Hide dbgs() stream for when built with -fmodules..

This should be more 'obviously' correct.
Sorry, some CMake confusion here....

Jun 14 2017, 11:34 AM
marsupial created D34214: Hide dbgs() stream for when built with -fmodules..
Jun 14 2017, 11:09 AM
marsupial updated the diff for D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

Formatting.

Jun 14 2017, 11:07 AM
marsupial updated the diff for D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

Relocate tests into Transforms/IPO.

Jun 14 2017, 7:11 AM

Jun 13 2017

marsupial updated the diff for D33515: Force RegisterStandardPasses to construct std::function in the IPO library..
Jun 13 2017, 5:21 PM
marsupial updated the diff for D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

Having trouble with the test part of this and CMake.

Jun 13 2017, 5:08 PM
marsupial updated the diff for D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

Add explicit dependency for CMake when built with LLVM_ENABLE_MODULES.

Jun 13 2017, 2:20 PM
marsupial committed rL305318: Revert r305313 & r305303, self-hosting build-bot isn’t liking it..
Revert r305313 & r305303, self-hosting build-bot isn’t liking it.
Jun 13 2017, 12:06 PM
marsupial committed rL305313: Fix self hosting build-bot failure from r305303 by adjusting….
Fix self hosting build-bot failure from r305303 by adjusting…
Jun 13 2017, 11:12 AM
marsupial committed rL305303: Force RegisterStandardPasses to construct std::function in the IPO library..
Force RegisterStandardPasses to construct std::function in the IPO library.
Jun 13 2017, 9:49 AM
marsupial closed D33515: Force RegisterStandardPasses to construct std::function in the IPO library. by committing rL305303: Force RegisterStandardPasses to construct std::function in the IPO library..
Jun 13 2017, 9:49 AM
marsupial updated the diff for D33515: Force RegisterStandardPasses to construct std::function in the IPO library..

Conflict resolution & additional comment.

Jun 13 2017, 9:40 AM

Jun 9 2017

marsupial added a comment to D33789: Export the required symbol from DynamicLibraryTests.

LGTM.

Jun 9 2017, 3:22 AM