Page MenuHomePhabricator

marsupial (Frederich Munch)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 10:43 PM (164 w, 6 d)

Recent Activity

Apr 13 2019

Herald added a project to D55699: Updated DynamicLibrary test to support static linking against MSVC RT.: Restricted Project.

Sorry for the tardiness of this...

  1. Could the the type change from std::string be to the new State type introduced (rather than int)
  2. Have all State variables default initialized to a value that would cause the test to fail.
Apr 13 2019, 5:21 PM · Restricted Project

Nov 27 2018

marsupial accepted D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

Crap your right...I might revisit this (as I think that's a bad move on my part).
I'd still like to give a moment for anyone else to chime in; otherwise, it shouldn't be a reason to hold this up.

Nov 27 2018, 8:55 PM

Nov 22 2018

marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

@lhames, any thoughts?

Nov 22 2018, 11:39 PM
marsupial added a comment to D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

I take it your using the MSVC generator?
I use ninja (which is a single-config build) all the time and it puts the the files into unittests/Support/DynamicLibrary ?
I'll try to spin up a Windows build in the next couple of days, but I'm not foreseeing my opinion being changed.

Nov 22 2018, 11:38 PM

Nov 19 2018

marsupial added a comment to D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

I'm not a fan of writing test stuff into <buildroot>/lib.

Nov 19 2018, 7:45 PM

Sep 9 2018

marsupial accepted D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Thanks.

Sep 9 2018, 8:15 PM
marsupial requested changes to D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Just maybe add a comment similar to the last line of the summary

Sep 9 2018, 9:27 AM

Mar 19 2018

marsupial updated the diff for D44643: [Lex] Change HeaderSearchOptions arguments to std::string..
Mar 19 2018, 12:38 PM · Restricted Project
marsupial created D44643: [Lex] Change HeaderSearchOptions arguments to std::string..
Mar 19 2018, 12:38 PM · Restricted Project

Mar 17 2018

marsupial accepted D44555: clang-interpreter example cmake fix.

Sorry 'bout that...
(CMake and quoting make dull boys)

Mar 17 2018, 7:23 PM

Mar 15 2018

marsupial added a comment to D44508: Remove unnecessary include from Driver.cpp.

Shouldn't the Translation Unit be responsible for knowing what it needs rather than hoping it's already been used somewhere up the chain.
Perhaps std::unique_ptr and std::make_pair are too low level and one can assume, but D44509 seems like a possibly overzealous application?

Mar 15 2018, 2:21 PM

Mar 14 2018

marsupial committed rL327531: [CMake] Properly quote string arguments to quiet errors from r327528 when built.
[CMake] Properly quote string arguments to quiet errors from r327528 when built
Mar 14 2018, 9:59 AM
marsupial committed rC327531: [CMake] Properly quote string arguments to quiet errors from r327528 when built.
[CMake] Properly quote string arguments to quiet errors from r327528 when built
Mar 14 2018, 9:59 AM
marsupial committed rL327528: Expand clang-interpreter with example of throwing in and from the JIT for….
Expand clang-interpreter with example of throwing in and from the JIT for…
Mar 14 2018, 9:07 AM
marsupial committed rC327528: Expand clang-interpreter with example of throwing in and from the JIT for….
Expand clang-interpreter with example of throwing in and from the JIT for…
Mar 14 2018, 9:07 AM
marsupial closed D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Mar 14 2018, 9:07 AM

Feb 27 2018

marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

I think what you're trying to do just isn't unsupported at this time.

So it is supported?

Feb 27 2018, 9:29 AM

Feb 25 2018

marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

I think what you're trying to do just isn't unsupported at this time.
Why not just use the JIT to compile the source for the on disk object at runtime?

Feb 25 2018, 1:03 PM

Feb 22 2018

marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

It's a little hard to understand the issue. To be clear:
This patch is fixing an instance that used to crash?
However there is a bit of manual setup for the JIT you are still not happy with?

Feb 22 2018, 9:11 AM

Feb 21 2018

marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Yes, thanks.
Just waiting till I had a moment to watch the new test on the bots.

Feb 21 2018, 9:34 AM
marsupial committed rL325700: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF
Feb 21 2018, 9:20 AM
marsupial closed D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Feb 21 2018, 9:20 AM

Feb 18 2018

marsupial added inline comments to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Feb 18 2018, 12:47 PM
marsupial updated the diff for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Changed name of function to write32BitOffset.

Feb 18 2018, 12:42 PM

Feb 17 2018

marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Ping

Feb 17 2018, 12:38 PM

Feb 16 2018

marsupial committed rC325352: Use Token::isOneOf method in Parser..
Use Token::isOneOf method in Parser.
Feb 16 2018, 8:09 AM
marsupial committed rL325352: Use Token::isOneOf method in Parser..
Use Token::isOneOf method in Parser.
Feb 16 2018, 8:09 AM
marsupial closed D36701: Use Token::isOneOf method in Parser..
Feb 16 2018, 8:09 AM

Feb 15 2018

marsupial added a comment to D36701: Use Token::isOneOf method in Parser..

Ping.

Feb 15 2018, 8:47 PM
marsupial added a comment to D36702: Make Parser::Consume*Token methods public..

Ping.

Feb 15 2018, 8:46 PM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Added test case for IMAGE_REL_AMD64_ADDR32NB with JIT and requested formatting changes.

Feb 15 2018, 12:11 PM
marsupial updated the diff for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Feb 15 2018, 12:09 PM

Dec 11 2017

marsupial added inline comments to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Dec 11 2017, 9:53 AM

Aug 14 2017

marsupial committed rL310906: Propagate error in LazyEmittingLayer::removeModule..
Propagate error in LazyEmittingLayer::removeModule.
Aug 14 2017, 7:28 PM
marsupial closed D36700: Propagate error in LazyEmittingLayer::removeModule. by committing rL310906: Propagate error in LazyEmittingLayer::removeModule..
Aug 14 2017, 7:28 PM
marsupial added a parent revision for D36702: Make Parser::Consume*Token methods public.: D36701: Use Token::isOneOf method in Parser..
Aug 14 2017, 11:16 AM
marsupial added a child revision for D36701: Use Token::isOneOf method in Parser.: D36702: Make Parser::Consume*Token methods public..
Aug 14 2017, 11:16 AM
marsupial created D36702: Make Parser::Consume*Token methods public..
Aug 14 2017, 11:15 AM
marsupial created D36701: Use Token::isOneOf method in Parser..
Aug 14 2017, 11:11 AM
marsupial added a comment to D36700: Propagate error in LazyEmittingLayer::removeModule..

I can commit this, but it should probably be merged into release_50 as well (?)

Aug 14 2017, 11:04 AM
marsupial created D36700: Propagate error in LazyEmittingLayer::removeModule..
Aug 14 2017, 10:45 AM

Aug 3 2017

marsupial accepted D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.

LGTM.

Aug 3 2017, 10:15 AM

Aug 2 2017

marsupial added inline comments to D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.
Aug 2 2017, 12:55 PM
marsupial added inline comments to D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.
Aug 2 2017, 6:29 AM

Aug 1 2017

marsupial added a comment to D36071: [builtins] Use Interlocked* intrinsics for atomics on MSVC.

I'm wondering if the #ifdef is now a dead code path entirely.
Do you have any insight into how ARM is getting __atomic_load_n and x86/64 not?

Aug 1 2017, 7:26 PM

Jul 30 2017

marsupial added inline comments to D30787: [builtins] Implement emulated TLS on Windows..
Jul 30 2017, 10:01 PM

Jul 28 2017

marsupial added a comment to D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Done, thanks. Would it be possible to look at D30709 as this depends on that. (ELF does not like Windows exceptions).

Jul 28 2017, 10:26 AM
marsupial updated the diff for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Use include guards, not pragma once and remove commented CMake debug lines.

Jul 28 2017, 10:23 AM

Jul 24 2017

marsupial added a comment to D33658: Extend DynamicLibrary class to be usable without loading permanently..

Ping,

Jul 24 2017, 1:58 PM
marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

Ping,

Jul 24 2017, 1:58 PM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Ping.

Jul 24 2017, 1:58 PM
marsupial added a comment to D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Ping.

Jul 24 2017, 1:57 PM
marsupial added a comment to D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

Ping.

Jul 24 2017, 1:57 PM

Jul 18 2017

marsupial retitled D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string. from Support: Add llvm::format_memory to convert number of bytes to human readable string. to Support: Add llvm::format_memory_size to convert number of bytes to human readable string..
Jul 18 2017, 8:53 AM
marsupial committed rL308321: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Make EHFrames available to sub-classes of RTDyldMemoryManager.
Jul 18 2017, 8:51 AM
marsupial closed D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager. by committing rL308321: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 18 2017, 8:51 AM

Jul 13 2017

marsupial added a comment to D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Done, and changed to 'windows.h', but blocked mingw from even attempting SEH for now.

Jul 13 2017, 3:24 PM
marsupial updated the diff for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

Blocked Win64 SEH for MingW entirely.
Theoretically it should be possible to throw a SEH from within mingw, but but I'm thinking clang may be generating exception handlers for the gcc runtime in that case.
I'll leave it up to someone with interest in such a mixture to figure that tout.

Jul 13 2017, 3:22 PM
marsupial updated the diff for D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

Added support for IEC, SI, and Customary output.

Jul 13 2017, 11:24 AM
marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

@joerg Any further thoughts/desire to review this?
Finishing this off would be nice and at least opens the door to using RTLD_LOCAL.

Jul 13 2017, 9:15 AM
marsupial committed rL307922: Support: Add llvm::center_justify..
Support: Add llvm::center_justify.
Jul 13 2017, 9:11 AM
marsupial closed D35278: Support: Add llvm::center_justify. by committing rL307922: Support: Add llvm::center_justify..
Jul 13 2017, 9:11 AM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

@compnerd is it possible to restart this.
I added an example to clang that verifies this works in D35103.
Just don't know how to trigger the relocation types in LLVM.

Jul 13 2017, 7:19 AM

Jul 12 2017

marsupial committed rL307849: Allow clients to specify search order of DynamicLibraries..
Allow clients to specify search order of DynamicLibraries.
Jul 12 2017, 2:23 PM
marsupial closed D33529: Allow clients to specify search order of DynamicLibraries. by committing rL307849: Allow clients to specify search order of DynamicLibraries..
Jul 12 2017, 2:23 PM
marsupial added a comment to D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

@ruiu
What about an optional argument to specific IEC suffixes.
Using IEC by default is fine by me, just that there is a way to not do so.

Jul 12 2017, 11:57 AM
marsupial added a comment to D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..

Ping.
@lhames Is there any chance to get this in before 5.0...it removes the need to store this same exact information 2x in our code base.

Jul 12 2017, 9:51 AM

Jul 11 2017

marsupial added a comment to D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

I appreciate the differences, but this is specifically to output an amount of memory in a human readable form.
Using KiB, MiB, etc may be pedantically correct, but it limits the usefulness of this to format text for a user who may have little knowledge of the differences between SI and IEC suffixes.
Every operating system I'm aware of does it this way and having output correlate to how the OS reports memory is more important.

Jul 11 2017, 8:02 PM
marsupial updated the diff for D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..

Fix typo in documentation.

Jul 11 2017, 5:43 PM
marsupial created D35284: Support: Add llvm::format_memory_size to convert number of bytes to human readable string..
Jul 11 2017, 5:41 PM
marsupial updated the diff for D35278: Support: Add llvm::center_justify..

Updated

Jul 11 2017, 4:44 PM
marsupial updated the diff for D35278: Support: Add llvm::center_justify..
Jul 11 2017, 4:35 PM
marsupial added a comment to D35278: Support: Add llvm::center_justify..

Ok,

Jul 11 2017, 4:01 PM
marsupial updated the diff for D35278: Support: Add llvm::center_justify..
Jul 11 2017, 4:01 PM
marsupial created D35278: Support: Add llvm::center_justify..
Jul 11 2017, 3:05 PM

Jul 9 2017

marsupial updated the diff for D33658: Extend DynamicLibrary class to be usable without loading permanently..

Use to std::pair instead of PointerIntPair, it's lighter for the temporary.

Jul 9 2017, 6:13 AM

Jul 7 2017

marsupial added a comment to D33529: Allow clients to specify search order of DynamicLibraries..

@v.g.vassilev @pcanal :
Can you provide a concrete example of a test in ROOT that this patch does not solve?

Jul 7 2017, 7:13 AM

Jul 6 2017

marsupial added parent revisions for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager., D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Jul 6 2017, 9:18 PM
marsupial added a child revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial added a child revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial removed child revisions for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF, D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:18 PM
marsupial removed a parent revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial removed a parent revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:18 PM
marsupial added a parent revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:17 PM
marsupial added child revisions for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager., D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Jul 6 2017, 9:17 PM
marsupial added a parent revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:17 PM
marsupial removed parent revisions for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF, D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:16 PM
marsupial removed a child revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:16 PM
marsupial removed a child revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:16 PM
marsupial added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Ping.

Jul 6 2017, 9:12 PM
marsupial added a parent revision for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Jul 6 2017, 9:12 PM
marsupial added a child revision for D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:12 PM
marsupial added a child revision for D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager.: D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:12 PM
marsupial added a parent revision for D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.: D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:12 PM
marsupial created D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..
Jul 6 2017, 9:11 PM
marsupial created D35102: Make EHFrames available to sub-classes of RTDyldMemoryManager..
Jul 6 2017, 9:06 PM
marsupial updated subscribers of D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

This has nothing to do with fixing your issue and is solely to allow clients to load via RTLD_LOCAL.
I don't see how D33529 could have broken anything as it is not committed yet. D33529 attempts to address what I understand is your issue.
If it's not working perhaps you could explain or provide a bit more info what doesn't work...(on that thread not here).
Perhaps @pcanal can help with that?

Jul 6 2017, 7:50 PM
marsupial updated the diff for D33529: Allow clients to specify search order of DynamicLibraries..

Typo & reword documentation.

Jul 6 2017, 7:27 PM
marsupial added a comment to D33657: Allow libraries to be loaded with RTLD_LOCAL on Unix..

From what I can tell, in LLVM the clients of this are solely clang and lldb.
Nothing should break for them as they explicitly search single libraries for symbols.

Jul 6 2017, 11:10 AM
marsupial added a comment to D33659: Extend DynamicLibrary class to be usable without loading permanently..

ping

Jul 6 2017, 10:23 AM