This is an archive of the discontinued LLVM Phabricator instance.

Export the required symbol from DynamicLibraryTests
ClosedPublic

Authored by chill on May 24 2017, 5:12 AM.

Details

Summary

Running unittests/Support/DynamicLibrary/DynamicLibraryTests fails when LLVM is configured with LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON, because the test's version script only contains symbols
extracted from the static libraries, that the test links with, but not those from the main object/executable itself. The patch
explicitly exports the one symbol needed by the test.

Diff Detail

Event Timeline

chill created this revision.May 24 2017, 5:12 AM
marsupial edited edge metadata.May 24 2017, 11:06 AM

Looks fine as long as you're confident this doesn't interfere when built without LLVM_EXPORT_SYMBOLS_FOR_PLUGINS.

Looks fine as long as you're confident this doesn't interfere when built without LLVM_EXPORT_SYMBOLS_FOR_PLUGINS.

Yes, regardless of the state of LLVM_EXPORT_SYMBOLS_FOR_PLUGINS, the build uses the given symbols list instead of
exporting all the symbols or exporting whatever symbols extract_symbols.py decides to export.

marsupial accepted this revision.May 25 2017, 9:20 AM
This revision is now accepted and ready to land.May 25 2017, 9:20 AM
chill added a comment.May 25 2017, 9:34 AM

Requesting a commit, please.

This revision was automatically updated to reflect the committed changes.
rogfer01 edited edge metadata.May 26 2017, 10:04 AM

Ok, I will revert this one. @chill will suggest another solution. Sorry for the fuss.