This is an archive of the discontinued LLVM Phabricator instance.

[Polly] [Docs] Use ReadTheDocs theme if available.
ClosedPublic

Authored by bollu on May 21 2017, 7:50 AM.

Download Raw Diff

Details

Reviewers

efriedma
jdoerfert
Meinersbur
gareevroman
sebpop
• zinob
huihuiz
pollydev
grosser

Commits

rG68ae83e68c6f: [Docs] Use ReadTheDocs theme if available.
rPLO303550: [Docs] Use ReadTheDocs theme if available.
rL303550: [Docs] Use ReadTheDocs theme if available.

Summary

Personal opinion: ReadTheDocs looks better and offers nicer functionality than default theme. I'm personally all for the theme, so I'd like to know objections to this if there are any.

Diff Detail

Build Status

Buildable 6628
Build 6628: arc lint + arc unit

Event Timeline

bollu created this revision.May 21 2017, 7:50 AM

bollu retitled this revision from [Polly] [Docs] Use ReadTheDocs theme if available. Personal opinion: ReadTheDocs looks better and offers nicer functionality than default theme. I'm personally all for the theme, so I'd like to know objections to this if there are any. to [Polly] [Docs] Use ReadTheDocs theme if available..May 21 2017, 7:53 AM

bollu edited the summary of this revision. (Show Details)

bollu added a subscriber: pollydev.

remove extra whitespace

grosser added a child revision: D33299: [Polly][CMake] Use the CMake Package instead of llvm-config in out-of-tree builds.May 22 2017, 1:01 AM

grosser removed a child revision: D33299: [Polly][CMake] Use the CMake Package instead of llvm-config in out-of-tree builds.

grosser added a parent revision: D33299: [Polly][CMake] Use the CMake Package instead of llvm-config in out-of-tree builds.

grosser edited parent revisions, added: D33386: [Polly] [Docs] Fix Sphinx documentation CMake check.; removed: D33299: [Polly][CMake] Use the CMake Package instead of llvm-config in out-of-tree builds.

Nice!

This revision is now accepted and ready to land.May 22 2017, 1:04 AM

Closed by commit rL303550: [Docs] Use ReadTheDocs theme if available. (authored by bollu). · Explain WhyMay 22 2017, 6:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

docs/

conf.py

9 lines

Diff 99696

docs/conf.py

	Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines
	# A list of ignored prefixes for module index sorting.			# A list of ignored prefixes for module index sorting.
	#modindex_common_prefix = []			#modindex_common_prefix = []


	# -- Options for HTML output ---------------------------------------------------			# -- Options for HTML output ---------------------------------------------------

	# The theme to use for HTML and HTML Help pages. See the documentation for			# The theme to use for HTML and HTML Help pages. See the documentation for
	# a list of builtin themes.			# a list of builtin themes.

				try:
				import sphinx_rtd_theme
				html_theme = "sphinx_rtd_theme"
				html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]
				except ModuleNotFoundError:
	html_theme = 'haiku'			html_theme = 'haiku'


	# Theme options are theme-specific and customize the look and feel of a theme			# Theme options are theme-specific and customize the look and feel of a theme
	# further. For a list of options available for each theme, see the			# further. For a list of options available for each theme, see the
	# documentation.			# documentation.
	#html_theme_options = {}			#html_theme_options = {}

	# Add any paths that contain custom themes here, relative to this directory.			# Add any paths that contain custom themes here, relative to this directory.
	#html_theme_path = []			#html_theme_path = []

	▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines