Page MenuHomePhabricator

[NFC] Use stdin for some tests instead of positional argument.
ClosedPublic

Authored by a.elovikov on May 9 2017, 3:48 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

a.elovikov created this revision.May 9 2017, 3:48 AM
spatel edited edge metadata.

Remove the '-o -' too?

Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?

  • Remove "-o -" too.

Remove the '-o -' too?

Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?

I have my compiler built in a cmplr/ directory which matches the CHECK-NOT: cmp check in these tests.

spatel accepted this revision.Jun 28 2017, 6:33 AM

Remove the '-o -' too?

Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?

I have my compiler built in a cmplr/ directory which matches the CHECK-NOT: cmp check in these tests.

Ah, right...CHECK-NOT is a poor way to verify output. Note that at least some ARM/Thumb triples are supported by utils/update_llc_test_checks.py, so a good follow-up patch would be to remove the current CHECK lines and let the script add complete checking (with no CHECK-NOT).

LGTM.

This revision is now accepted and ready to land.Jun 28 2017, 6:33 AM
This revision was automatically updated to reflect the committed changes.