This is an archive of the discontinued LLVM Phabricator instance.

Differential D32994

[NFC] Use stdin for some tests instead of positional argument.
ClosedPublic

Authored by a.elovikov on May 9 2017, 3:48 AM.

Details

Reviewers
rengolin
spatel
efriedma
RKSimon
Commits
rG1925594ea074: [NFC] Use stdin for some tests instead of positional argument.
rL306684: [NFC] Use stdin for some tests instead of positional argument.
Summary

Otherwise unexpected matches with the path to the tests might happen.

Diff Detail

Repository
rL LLVM

Event Timeline

a.elovikov created this revision.May 9 2017, 3:48 AM
Herald added a subscriber: javed.absar. · View Herald TranscriptMay 9 2017, 3:48 AM
a.elovikov added a subscriber: n.bozhenov.May 9 2017, 3:49 AM
a.elovikov added a reviewer: rengolin.May 9 2017, 8:20 AM
a.elovikov added a comment.May 25 2017, 7:08 AM

Ping.

a.elovikov added reviewers: spatel, efriedma.Jun 28 2017, 1:40 AM

Ping.

spatel added a reviewer: RKSimon.Jun 28 2017, 6:07 AM
spatel edited edge metadata.

Remove the '-o -' too?

Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?

a.elovikov updated this revision to Diff 104404.Jun 28 2017, 6:24 AM
  • Remove "-o -" too.
a.elovikov added a comment.Jun 28 2017, 6:26 AM
In D32994#793670, @spatel wrote:

Remove the '-o -' too?

Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?

I have my compiler built in a cmplr/ directory which matches the CHECK-NOT: cmp check in these tests.

spatel accepted this revision.Jun 28 2017, 6:33 AM
In D32994#793690, @a.elovikov wrote:
In D32994#793670, @spatel wrote:

Remove the '-o -' too?

Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?

I have my compiler built in a cmplr/ directory which matches the CHECK-NOT: cmp check in these tests.

Ah, right...CHECK-NOT is a poor way to verify output. Note that at least some ARM/Thumb triples are supported by utils/update_llc_test_checks.py, so a good follow-up patch would be to remove the current CHECK lines and let the script add complete checking (with no CHECK-NOT).

LGTM.

This revision is now accepted and ready to land.Jun 28 2017, 6:33 AM
Closed by commit rL306684: [NFC] Use stdin for some tests instead of positional argument. (authored by n.bozhenov). · Explain WhyJun 29 2017, 7:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
CodeGen/
ARM/
2 lines
4 lines
Thumb/
2 lines

Diff 104651

llvm/trunk/test/CodeGen/ARM/long-setcc.ll

; RUN: llc -mtriple=arm-eabi %s -o - | FileCheck %s ; RUN: llc -mtriple=arm-eabi < %s | FileCheck %s
define i1 @t1(i64 %x) { define i1 @t1(i64 %x) {
%B = icmp slt i64 %x, 0 %B = icmp slt i64 %x, 0
ret i1 %B ret i1 %B
} }
define i1 @t2(i64 %x) { define i1 @t2(i64 %x) {
%tmp = icmp ult i64 %x, 4294967296 %tmp = icmp ult i64 %x, 4294967296
Show All 11 Lines

llvm/trunk/test/CodeGen/ARM/thumb2-it-block.ll

; RUN: llc -mtriple=thumb-eabi -mcpu=arm1156t2-s -mattr=+thumb2 %s -o - | FileCheck %s ; RUN: llc -mtriple=thumb-eabi -mcpu=arm1156t2-s -mattr=+thumb2 < %s | FileCheck %s
; RUN: llc -mtriple=thumbv8 %s -o - | FileCheck %s ; RUN: llc -mtriple=thumbv8 < %s | FileCheck %s
; PR11107 ; PR11107
define i32 @test(i32 %a, i32 %b) { define i32 @test(i32 %a, i32 %b) {
entry: entry:
%cmp1 = icmp slt i32 %a, 0 %cmp1 = icmp slt i32 %a, 0
%sub1 = sub nsw i32 0, %a %sub1 = sub nsw i32 0, %a
%abs1 = select i1 %cmp1, i32 %sub1, i32 %a %abs1 = select i1 %cmp1, i32 %sub1, i32 %a
%cmp2 = icmp slt i32 %b, 0 %cmp2 = icmp slt i32 %b, 0
Show All 16 Lines

llvm/trunk/test/CodeGen/Thumb/long-setcc.ll

; RUN: llc -mtriple=thumb-eabi %s -o - | FileCheck %s ; RUN: llc -mtriple=thumb-eabi < %s | FileCheck %s
define i1 @t1(i64 %x) { define i1 @t1(i64 %x) {
%B = icmp slt i64 %x, 0 %B = icmp slt i64 %x, 0
ret i1 %B ret i1 %B
} }
define i1 @t2(i64 %x) { define i1 @t2(i64 %x) {
%tmp = icmp ult i64 %x, 4294967296 %tmp = icmp ult i64 %x, 4294967296
Show All 13 Lines