Page MenuHomePhabricator

[mips] Impose a threshold for coercion of aggregates
ClosedPublic

Authored by smaksimovic on May 5 2017, 4:28 AM.

Details

Summary

Modified MipsABIInfo::classifyArgumentType so that it now coerces aggregate structures
only if the size of said aggregate is less than 16/64 bytes, depending on the ABI.

Diff Detail

Repository
rL LLVM

Event Timeline

smaksimovic created this revision.May 5 2017, 4:28 AM
sdardis accepted this revision.May 9 2017, 4:21 AM

LGTM.

test/CodeGen/mips-aggregate-arg.c
3 ↗(On Diff #97929)

Space after the -target-abi n64

This revision is now accepted and ready to land.May 9 2017, 4:21 AM

Spotted a minor nit.

test/CodeGen/mips-aggregate-arg.c
36 ↗(On Diff #97929)

Nit: spurious whitespace here.

smaksimovic updated this revision to Diff 98269.May 9 2017, 5:12 AM

Thanks, fixed.

This revision was automatically updated to reflect the committed changes.