Add support for openSUSE ARM Triples
ClosedPublic

Authored by ismail on Apr 21 2017, 4:06 AM.

Details

Summary

Add support for armv6hl-suse-linux-gnueabi and armv7hl-suse-linux-gnueabi triples used by openSUSE/SUSE.

Diff Detail

ismail created this revision.Apr 21 2017, 4:06 AM

Nothing new here, pretty much standard. No "gnueabihf"?

Nothing new here, pretty much standard. No "gnueabihf"?

Yes openSUSE prefers the "hl" prefix to mean HardFloat.

Yes openSUSE prefers the "hl" prefix to mean HardFloat.

I'm not sure that'll do what you expect it, though. Having the "hf" at the end of the triple has some magical effect on the Triple class.

But at the very least, you should make sure that float-abi is indeed hard.

I'm adding Diana and Saleem, who have had more exposure to float abi shenanigans than I have, recently.

Yes openSUSE prefers the "hl" prefix to mean HardFloat.

I'm not sure that'll do what you expect it, though. Having the "hf" at the end of the triple has some magical effect on the Triple class.

Indeed it doesn't hence we set the correct CFLAGS/CXXFLAGS separately for the moment.

But at the very least, you should make sure that float-abi is indeed hard.

Yes I'll work on that next. This is just to get the triple correct, which lets me bootstrap the compiler.

rengolin accepted this revision.Apr 21 2017, 5:32 AM

Ok, I see no harm in letting you work upstream, since no one should be relying on the correct behaviour on opensuse for now. LGTM. Thanks!

This revision is now accepted and ready to land.Apr 21 2017, 5:32 AM
ismail closed this revision.Apr 21 2017, 5:39 AM