This is an archive of the discontinued LLVM Phabricator instance.

[coff] use newlines instead of spaces as separators in msvclto response file
ClosedPublic

Authored by inglorion on Apr 18 2017, 12:59 PM.

Event Timeline

inglorion created this revision.Apr 18 2017, 12:59 PM
davide added a subscriber: davide.Apr 18 2017, 1:05 PM

I'm surprised we don't have a test for this? (I assume it needs link.exe but that should be available on some bots)

@davide, we could extract the response file generation into its own function and write a unit test for it. On the other hand, I don't want to spend too much time polishing msvclto - I'd rather spend time on making it unnecessary.

@davide, we could extract the response file generation into its own function and write a unit test for it. On the other hand, I don't want to spend too much time polishing msvclto - I'd rather spend time on making it unnecessary.

If it will go away soon, fair enough.

hans accepted this revision.Apr 18 2017, 2:46 PM

lgtm

This revision is now accepted and ready to land.Apr 18 2017, 2:46 PM
This revision was automatically updated to reflect the committed changes.