This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GFX9: Fix shared and private aperture queries
ClosedPublic

Authored by kzhuravl on Apr 6 2017, 1:33 PM.

Diff Detail

Event Timeline

kzhuravl created this revision.Apr 6 2017, 1:33 PM
arsenm added inline comments.Apr 6 2017, 1:37 PM
lib/Target/AMDGPU/SIISelLowering.cpp
2356

What's wrong with using these now?

lib/Target/AMDGPU/SIRegisterInfo.td
47–51

Why delete this?

kzhuravl updated this revision to Diff 94441.Apr 6 2017, 2:42 PM

Leave register definitions untouched.

kzhuravl added inline comments.Apr 6 2017, 2:44 PM
lib/Target/AMDGPU/SIISelLowering.cpp
2356

It requires a reorg in register classes, which I was planning to do in a separate patch if that is ok?

arsenm accepted this revision.Apr 6 2017, 3:34 PM

LGTM

This revision is now accepted and ready to land.Apr 6 2017, 3:34 PM
This revision was automatically updated to reflect the committed changes.
test/CodeGen/AMDGPU/addrspacecast.ll